starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #9248] [MERGED] Fixes #9138 - Prevent searching when pressing enter in Quick Search #13442

New Issue
Closed
opened 2025-12-29 22:27:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:27:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/9248
Author: @kkthxbye-code
Created: 4/28/2022
Status: ✅ Merged
Merged: 4/28/2022
Merged by: @jeremystretch

Base: develop ← Head: fix-9138

📝 Commits (1)

  • 314c41f Prevent searching when pressing enter in Quick Search

📊 Changes

20 files changed (+74 additions, -53 deletions)

View changed files

📝 netbox/templates/dcim/device/consoleports.html (+2 -1)
📝 netbox/templates/dcim/device/consoleserverports.html (+2 -1)
📝 netbox/templates/dcim/device/devicebays.html (+2 -1)
📝 netbox/templates/dcim/device/frontports.html (+2 -1)
📝 netbox/templates/dcim/device/interfaces.html (+36 -34)
📝 netbox/templates/dcim/device/inventory.html (+2 -1)
📝 netbox/templates/dcim/device/modulebays.html (+2 -1)
📝 netbox/templates/dcim/device/poweroutlets.html (+2 -1)
📝 netbox/templates/dcim/device/powerports.html (+2 -1)
📝 netbox/templates/dcim/device/rearports.html (+2 -1)
📝 netbox/templates/ipam/aggregate/prefixes.html (+2 -1)
📝 netbox/templates/ipam/iprange/ip_addresses.html (+2 -1)
📝 netbox/templates/ipam/prefix/ip_addresses.html (+2 -1)
📝 netbox/templates/ipam/prefix/ip_ranges.html (+2 -1)
📝 netbox/templates/ipam/prefix/prefixes.html (+2 -1)
📝 netbox/templates/ipam/vlan/interfaces.html (+2 -1)
📝 netbox/templates/ipam/vlan/vminterfaces.html (+2 -1)
📝 netbox/templates/virtualization/cluster/devices.html (+2 -1)
📝 netbox/templates/virtualization/cluster/virtual_machines.html (+2 -1)
📝 netbox/templates/virtualization/virtualmachine/interfaces.html (+2 -1)

📄 Description

Fixes: #9138

Move all includes of inc/table_controls_htmx.html out of the table forms. This matches the existing setup in object_list.hml, which is why the bug only occurred in some cases.

I tested quick search in all the tables I changed, and there seem to be no ill effects of the change, however there could be cases I haven't thought about (I wish UI testing was easier to setup).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/9248 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 4/28/2022 **Status:** ✅ Merged **Merged:** 4/28/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `fix-9138` --- ### 📝 Commits (1) - [`314c41f`](https://github.com/netbox-community/netbox/commit/314c41f47f8eba4df84688a478452b5178b091d7) Prevent searching when pressing enter in Quick Search ### 📊 Changes **20 files changed** (+74 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/dcim/device/consoleports.html` (+2 -1) 📝 `netbox/templates/dcim/device/consoleserverports.html` (+2 -1) 📝 `netbox/templates/dcim/device/devicebays.html` (+2 -1) 📝 `netbox/templates/dcim/device/frontports.html` (+2 -1) 📝 `netbox/templates/dcim/device/interfaces.html` (+36 -34) 📝 `netbox/templates/dcim/device/inventory.html` (+2 -1) 📝 `netbox/templates/dcim/device/modulebays.html` (+2 -1) 📝 `netbox/templates/dcim/device/poweroutlets.html` (+2 -1) 📝 `netbox/templates/dcim/device/powerports.html` (+2 -1) 📝 `netbox/templates/dcim/device/rearports.html` (+2 -1) 📝 `netbox/templates/ipam/aggregate/prefixes.html` (+2 -1) 📝 `netbox/templates/ipam/iprange/ip_addresses.html` (+2 -1) 📝 `netbox/templates/ipam/prefix/ip_addresses.html` (+2 -1) 📝 `netbox/templates/ipam/prefix/ip_ranges.html` (+2 -1) 📝 `netbox/templates/ipam/prefix/prefixes.html` (+2 -1) 📝 `netbox/templates/ipam/vlan/interfaces.html` (+2 -1) 📝 `netbox/templates/ipam/vlan/vminterfaces.html` (+2 -1) 📝 `netbox/templates/virtualization/cluster/devices.html` (+2 -1) 📝 `netbox/templates/virtualization/cluster/virtual_machines.html` (+2 -1) 📝 `netbox/templates/virtualization/virtualmachine/interfaces.html` (+2 -1) </details> ### 📄 Description ### Fixes: #9138 Move all includes of `inc/table_controls_htmx.html` out of the table forms. This matches the existing setup in `object_list.hml`, which is why the bug only occurred in some cases. I tested quick search in all the tables I changed, and there seem to be no ill effects of the change, however there could be cases I haven't thought about (I wish UI testing was easier to setup). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:27:26 +01:00
adam closed this issue 2025-12-29 22:27:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13442
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?