starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #8510] [MERGED] Closes #8032: Upgrade to Django 4.0 #13361

New Issue
Closed
opened 2025-12-29 22:26:58 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/8510
Author: @jeremystretch
Created: 2/1/2022
Status: ✅ Merged
Merged: 2/7/2022
Merged by: @jeremystretch

Base: feature ← Head: 8032-django-40

📝 Commits (5)

  • ef75f7e Upgrade to Django 4.0
  • 7611cfd Tweak related names in old migrations to avoid creating new ones
  • 630ff2a Remove dependency on is_safe_url()
  • 0e95ca7 Fix ProgrammingError exception when annotating config context data
  • 9ac769e Pull graphene-django from v2 branch

📊 Changes

12 files changed (+76 additions, -82 deletions)

View changed files

📝 netbox/dcim/migrations/0002_squashed.py (+9 -9)
📝 netbox/dcim/migrations/0003_squashed_0130.py (+8 -8)
📝 netbox/dcim/migrations/0146_modules.py (+23 -23)
📝 netbox/dcim/migrations/0149_inventoryitem_templates.py (+1 -1)
📝 netbox/extras/migrations/0001_squashed.py (+2 -2)
📝 netbox/extras/migrations/0002_squashed_0059.py (+11 -11)
📝 netbox/extras/migrations/0068_configcontext_cluster_types.py (+1 -1)
📝 netbox/extras/querysets.py (+1 -1)
📝 netbox/netbox/views/generic/object_views.py (+3 -7)
📝 netbox/users/views.py (+9 -10)
📝 netbox/utilities/views.py (+3 -6)
📝 requirements.txt (+5 -3)

📄 Description

Closes: #8032

NOTE: Because graphene-django does not yet support Django v4.0, this branch is currently using a fork which has added v4.0 support. Once the relevant PR has been merged, this will be returned to the normal package.

  • Bumps Django to 4.0
  • Tweak old migrations to avoid introducing no-op migrations
  • Remove dependency on private is_safe_url() function

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/8510 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/1/2022 **Status:** ✅ Merged **Merged:** 2/7/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `8032-django-40` --- ### 📝 Commits (5) - [`ef75f7e`](https://github.com/netbox-community/netbox/commit/ef75f7e65030121e22a63e30e1c76f4d1f31c9ba) Upgrade to Django 4.0 - [`7611cfd`](https://github.com/netbox-community/netbox/commit/7611cfddae9f127ccad934923198bf09fe7ddb95) Tweak related names in old migrations to avoid creating new ones - [`630ff2a`](https://github.com/netbox-community/netbox/commit/630ff2abb4f9368bb2329579b0b0d6c00af3bd3d) Remove dependency on is_safe_url() - [`0e95ca7`](https://github.com/netbox-community/netbox/commit/0e95ca7b69148525cedd91c99dfaa81fc3d68332) Fix ProgrammingError exception when annotating config context data - [`9ac769e`](https://github.com/netbox-community/netbox/commit/9ac769e4f851356cdcd4991542d40cba47339bf7) Pull graphene-django from v2 branch ### 📊 Changes **12 files changed** (+76 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/migrations/0002_squashed.py` (+9 -9) 📝 `netbox/dcim/migrations/0003_squashed_0130.py` (+8 -8) 📝 `netbox/dcim/migrations/0146_modules.py` (+23 -23) 📝 `netbox/dcim/migrations/0149_inventoryitem_templates.py` (+1 -1) 📝 `netbox/extras/migrations/0001_squashed.py` (+2 -2) 📝 `netbox/extras/migrations/0002_squashed_0059.py` (+11 -11) 📝 `netbox/extras/migrations/0068_configcontext_cluster_types.py` (+1 -1) 📝 `netbox/extras/querysets.py` (+1 -1) 📝 `netbox/netbox/views/generic/object_views.py` (+3 -7) 📝 `netbox/users/views.py` (+9 -10) 📝 `netbox/utilities/views.py` (+3 -6) 📝 `requirements.txt` (+5 -3) </details> ### 📄 Description ### Closes: #8032 **NOTE:** Because graphene-django does not yet support Django v4.0, this branch is currently using a fork which has added v4.0 support. Once the relevant PR has been merged, this will be returned to the normal package. - Bumps Django to 4.0 - Tweak old migrations to avoid introducing [no-op migrations](https://docs.djangoproject.com/en/4.0/releases/4.0/#migrations-autodetector-changes) - Remove dependency on private `is_safe_url()` function --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:58 +01:00
adam closed this issue 2025-12-29 22:26:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?