starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #8247] [MERGED] Closes #8231: Use HTMX for object deletion confirmations #13335

New Issue
Closed
opened 2025-12-29 22:26:50 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/8247
Author: @jeremystretch
Created: 1/5/2022
Status: ✅ Merged
Merged: 1/5/2022
Merged by: @jeremystretch

Base: develop ← Head: 8231-htmx-confirmation-dialogs

📝 Commits (2)

📊 Changes

8 files changed (+69 additions, -19 deletions)

View changed files

📝 netbox/ipam/views.py (+0 -1)
📝 netbox/netbox/views/generic.py (+16 -4)
📝 netbox/templates/generic/object.html (+5 -1)
📝 netbox/templates/generic/object_delete.html (+13 -6)
➕ netbox/templates/htmx/delete_form.html (+20 -0)
➕ netbox/templates/inc/htmx_modal.html (+7 -0)
➖ netbox/templates/ipam/prefix_delete.html (+0 -5)
📝 netbox/utilities/templates/buttons/delete.html (+8 -2)

📄 Description

Closes: #8231

  • Extend ObjectDeleteView to support HTMX responses
  • Refactor the object_delete.html template
  • Include an HTMX-backed modal component on all object views
  • Update the "delete" object button to use the HTMX-backed modal to render the confirmation form

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/8247 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 1/5/2022 **Status:** ✅ Merged **Merged:** 1/5/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `8231-htmx-confirmation-dialogs` --- ### 📝 Commits (2) - [`443b4cc`](https://github.com/netbox-community/netbox/commit/443b4ccc573f07f582f0c9ca8485f15d3517c71d) Initial work on #8231 - [`ccda734`](https://github.com/netbox-community/netbox/commit/ccda73494f5f4b104f280865b5c99eb43014cb0e) Center modal dialog vertically ### 📊 Changes **8 files changed** (+69 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/views.py` (+0 -1) 📝 `netbox/netbox/views/generic.py` (+16 -4) 📝 `netbox/templates/generic/object.html` (+5 -1) 📝 `netbox/templates/generic/object_delete.html` (+13 -6) ➕ `netbox/templates/htmx/delete_form.html` (+20 -0) ➕ `netbox/templates/inc/htmx_modal.html` (+7 -0) ➖ `netbox/templates/ipam/prefix_delete.html` (+0 -5) 📝 `netbox/utilities/templates/buttons/delete.html` (+8 -2) </details> ### 📄 Description ### Closes: #8231 - Extend ObjectDeleteView to support HTMX responses - Refactor the `object_delete.html` template - Include an HTMX-backed modal component on all object views - Update the "delete" object button to use the HTMX-backed modal to render the confirmation form --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:50 +01:00
adam closed this issue 2025-12-29 22:26:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13335
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?