[PR #8063] [MERGED] Get_Environment from napalm should not need any decoding #13313

New Issue

adam · 2025-12-29T22:26:42+01:00

adam commented

2025-12-29 22:26:42 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/8063
Author: @rizlas
Created: 12/14/2021
Status: ✅ Merged
Merged: 12/21/2021
Merged by: @jeremystretch

Base: develop ← Head: develop

📝 Commits (2)

2ec64a2 Get_Environment from napalm should not need any decoding
39a0b15 Update netbox/dcim/api/views.py

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/dcim/api/views.py (+1 -1)

📄 Description

Fixes: #7246

As stated already in the issue, napalm method get_environment is currently failing. Dictionary coming from napalm driver are already sanitized and therefore param decode_keys should be set to false before calling decode_dict.

https://github.com/napalm-automation/napalm/blob/develop/napalm/base/base.py#L465
https://github.com/napalm-automation/napalm/blob/develop/napalm/ios/ios.py#L2197

This was tested with ios driver.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/8063 **Author:** [@rizlas](https://github.com/rizlas) **Created:** 12/14/2021 **Status:** ✅ Merged **Merged:** 12/21/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`2ec64a2`](https://github.com/netbox-community/netbox/commit/2ec64a2ea25848e1c4770a65c99920da599553d3) Get_Environment from napalm should not need any decoding - [`39a0b15`](https://github.com/netbox-community/netbox/commit/39a0b15df4b93d6c3b6b19cc02752bc19cc173fa) Update netbox/dcim/api/views.py ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/views.py` (+1 -1) </details> ### 📄 Description ### Fixes: #7246 As stated already in the issue, napalm method `get_environment` is currently failing. Dictionary coming from napalm driver are already sanitized and therefore param decode_keys should be set to false before calling decode_dict. https://github.com/napalm-automation/napalm/blob/develop/napalm/base/base.py#L465 https://github.com/napalm-automation/napalm/blob/develop/napalm/ios/ios.py#L2197 This was tested with ios driver. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:26:42 +01:00

adam closed this issue

2025-12-29 22:26:42 +01:00

adam referenced this issue

2025-12-29 23:23:12 +01:00

[PR #13568] [MERGED] Adds parent filter on iprange #14215

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13313