[PR #7928] [MERGED] Fix #7751: LDAP: Only get API user from ldap when FIND_GROUP_PERMS is on #13299

New Issue

adam · 2025-12-29T22:26:37+01:00

adam commented

2025-12-29 22:26:37 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7928
Author: @kkthxbye-code
Created: 11/25/2021
Status: ✅ Merged
Merged: 12/3/2021
Merged by: @jeremystretch

Base: develop ← Head: fix-7751

📝 Commits (1)

8bb0cba Fix #7751 - LDAP: Only get API user from ldap when FIND_GROUP_PERMS is enabled

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 netbox/netbox/api/authentication.py (+7 -4)

📄 Description

Fixes: #7751

When using the LDAP backend for auth, all API requests would refresh the user (local or LDAP created) from the LDAP server, causing performance issues. With this fix, the user is only refreshed when FIND_GROUP_PERMS is enabled.

I tested all combinations I could think of. Not sure if this change in logic warrants a warning in the release notes. The changes for different combinations of settings can be seen in the issue: #7751

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7928 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 11/25/2021 **Status:** ✅ Merged **Merged:** 12/3/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `fix-7751` --- ### 📝 Commits (1) - [`8bb0cba`](https://github.com/netbox-community/netbox/commit/8bb0cba949ca6fd4fe3d48b1cec0153ab1ae4817) Fix #7751 - LDAP: Only get API user from ldap when FIND_GROUP_PERMS is enabled ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/api/authentication.py` (+7 -4) </details> ### 📄 Description ### Fixes: #7751 When using the LDAP backend for auth, all API requests would refresh the user (local or LDAP created) from the LDAP server, causing performance issues. With this fix, the user is only refreshed when FIND_GROUP_PERMS is enabled. I tested all combinations I could think of. Not sure if this change in logic warrants a warning in the release notes. The changes for different combinations of settings can be seen in the issue: #7751 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:26:37 +01:00

adam closed this issue

2025-12-29 22:26:37 +01:00

adam referenced this issue

2025-12-29 23:24:03 +01:00

[PR #14289] [MERGED] Closes #13299: Improve options for controlling custom field visibility #14361

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13299