[PR #7861] [MERGED] Fixes #7657: Make request/webhook caching thread-safe #13292

New Issue

adam · 2025-12-29T22:26:35+01:00

adam commented

2025-12-29 22:26:35 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7861
Author: @jeremystretch
Created: 11/17/2021
Status: ✅ Merged
Merged: 11/24/2021
Merged by: @jeremystretch

Base: develop ← Head: 7657-threadsafe-changelog

📝 Commits (1)

0d60099 Move request object and webhook queue to TLS

📊 Changes

6 files changed (+42 additions, -29 deletions)

View changed files

📝 netbox/extras/context_managers.py (+10 -10)
📝 netbox/extras/signals.py (+17 -9)
📝 netbox/netbox/__init__.py (+3 -0)
📝 netbox/netbox/middleware.py (+3 -3)
➕ netbox/netbox/request_context.py (+9 -0)
📝 netbox/utilities/utils.py (+0 -7)

📄 Description

Fixes: #7657

Employ thread-local storage for capturing the request object and webhook queue
Remove currying of these variables into the signal handlers

Initial testing seems to confirm that this resolves the bug without any negative effects, however further testing by other individuals would be greatly appreciated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7861 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/17/2021 **Status:** ✅ Merged **Merged:** 11/24/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `7657-threadsafe-changelog` --- ### 📝 Commits (1) - [`0d60099`](https://github.com/netbox-community/netbox/commit/0d600995883ce3ec5758f850d5fc7fc2f823e0d1) Move request object and webhook queue to TLS ### 📊 Changes **6 files changed** (+42 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/context_managers.py` (+10 -10) 📝 `netbox/extras/signals.py` (+17 -9) 📝 `netbox/netbox/__init__.py` (+3 -0) 📝 `netbox/netbox/middleware.py` (+3 -3) ➕ `netbox/netbox/request_context.py` (+9 -0) 📝 `netbox/utilities/utils.py` (+0 -7) </details> ### 📄 Description ### Fixes: #7657 - Employ thread-local storage for capturing the request object and webhook queue - Remove currying of these variables into the signal handlers Initial testing seems to confirm that this resolves the bug without any negative effects, however further testing by other individuals would be greatly appreciated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:26:35 +01:00

adam closed this issue

2025-12-29 22:26:35 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13292