starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #7678] [MERGED] Closes #6615: Enable filter lookups for custom fields #13266

New Issue
Closed
opened 2025-12-29 22:26:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7678
Author: @jeremystretch
Created: 10/28/2021
Status: ✅ Merged
Merged: 10/29/2021
Merged by: @jeremystretch

Base: feature ← Head: 6615-custom-field-filters

📝 Commits (6)

  • 6377d47 Refactor generation of additional lookup filters
  • 7c60089 Ditch CustomFieldFilter
  • 2e0f15b Automatically add additional lookup filters for custom fields
  • 1ce9192 Move MACAddressField to utilities
  • 3220504 Use multi-value filters for custom fields
  • 696fe7b Add tests for custom field lookups

📊 Changes

9 files changed (+221 additions, -151 deletions)

View changed files

📝 netbox/dcim/forms/__init__.py (+0 -1)
➖ netbox/dcim/forms/fields.py (+0 -25)
📝 netbox/extras/filters.py (+0 -36)
📝 netbox/extras/filtersets.py (+0 -7)
📝 netbox/extras/models/customfields.py (+54 -0)
📝 netbox/extras/tests/test_customfields.py (+65 -26)
📝 netbox/netbox/filtersets.py (+77 -55)
📝 netbox/utilities/filters.py (+1 -1)
📝 netbox/utilities/forms/fields.py (+24 -0)

📄 Description

Closes: #6615

  • Refactors BaseFilterSet
  • Ditches CustomFieldFilter in favor of stock filter intstances
  • Add to_filter() method on CustomField model
  • Moves MACAddressField form field to utilities (to resolve a circular import)
  • Enables multi-value filters for custom fields

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7678 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 10/28/2021 **Status:** ✅ Merged **Merged:** 10/29/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `6615-custom-field-filters` --- ### 📝 Commits (6) - [`6377d47`](https://github.com/netbox-community/netbox/commit/6377d475fc13b44765c3918736596d061329ceaa) Refactor generation of additional lookup filters - [`7c60089`](https://github.com/netbox-community/netbox/commit/7c60089692d853c7db2bb3af623bf28347697596) Ditch CustomFieldFilter - [`2e0f15b`](https://github.com/netbox-community/netbox/commit/2e0f15b35fbe72ab1f9b890dd7740e6e94d81550) Automatically add additional lookup filters for custom fields - [`1ce9192`](https://github.com/netbox-community/netbox/commit/1ce9192369f78de6edf388103f08622036b484b2) Move MACAddressField to utilities - [`3220504`](https://github.com/netbox-community/netbox/commit/32205045bae2e894886737df78861711be6b9d3e) Use multi-value filters for custom fields - [`696fe7b`](https://github.com/netbox-community/netbox/commit/696fe7bc0d70da66e5e109f3dcf47761a1f67109) Add tests for custom field lookups ### 📊 Changes **9 files changed** (+221 additions, -151 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/__init__.py` (+0 -1) ➖ `netbox/dcim/forms/fields.py` (+0 -25) 📝 `netbox/extras/filters.py` (+0 -36) 📝 `netbox/extras/filtersets.py` (+0 -7) 📝 `netbox/extras/models/customfields.py` (+54 -0) 📝 `netbox/extras/tests/test_customfields.py` (+65 -26) 📝 `netbox/netbox/filtersets.py` (+77 -55) 📝 `netbox/utilities/filters.py` (+1 -1) 📝 `netbox/utilities/forms/fields.py` (+24 -0) </details> ### 📄 Description ### Closes: #6615 - Refactors BaseFilterSet - Ditches CustomFieldFilter in favor of stock filter intstances - Add `to_filter()` method on CustomField model - Moves MACAddressField form field to utilities (to resolve a circular import) - Enables multi-value filters for custom fields --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:26 +01:00
adam closed this issue 2025-12-29 22:26:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?