starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #7623] [CLOSED] Add 802.1ad (QinQ) to Interface Mode Choices #13260

New Issue
Closed
opened 2025-12-29 22:26:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7623
Author: @rsp2k
Created: 10/23/2021
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (9)

📊 Changes

4 files changed (+12 additions, -2 deletions)

View changed files

📝 netbox/dcim/choices.py (+2 -0)
📝 netbox/dcim/forms/common.py (+7 -1)
📝 netbox/dcim/forms/models.py (+2 -1)
📝 netbox/project-static/src/forms/vlanTags.ts (+1 -0)

📄 Description

Fixes: 116

Add 802.1ad [Q-in-Q] (https://en.wikipedia.org/wiki/IEEE_802.1ad) to Interface Types

  • The previous feature requests have greatly complicated this. Bare minimum needed is simply the option in InterfaceModeChoices. When an interface is in the q-in-q mode. As far as Netbox is concerned, it's a "special" access port. I'm looking for this field to use for automating switchport configuration. Yes, I can add a custom field, but this is a IEEE 802.x type, it should be an option.

Below is an example of the relevant portions of a port configured for q-in-q (Cisco Catalyst switch, I'm guessing others are similar):

interface GigabitEthernet1/0/11
switchport access vlan 1000
switchport mode dot1q-tunnel

As opposed to a "tagged" port:

interface TenGigabitEthernet1/1/3
switchport trunk native vlan 1001
switchport mode trunk
switchport trunk allowed vlan 10,20,30,55-60

Or a "tagged-all" port:

interface TenGigabitEthernet1/1/3
switchport trunk native vlan 1001
switchport mode trunk
switchport trunk allowed vlan all

Or an "access" port:
interface TenGigabitEthernet1/1/4
switchport trunk native vlan 1002
switchport mode access

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7623 **Author:** [@rsp2k](https://github.com/rsp2k) **Created:** 10/23/2021 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (9) - [`b554707`](https://github.com/netbox-community/netbox/commit/b5547072f0c6dd7463959bc27f455e1da963369b) Add 802.1ad (QinQ) to Interface Mode Choices - [`28deda9`](https://github.com/netbox-community/netbox/commit/28deda9df1ef90efac35c772ac652eae4f2b3fc5) Check for tagged vlans on Q-in-Q interfaces - [`69eed98`](https://github.com/netbox-community/netbox/commit/69eed9859b3886d4e96b74063617965ad1c68dd0) Add condition for dot1q-tunnel - [`c4d3d21`](https://github.com/netbox-community/netbox/commit/c4d3d215daf2f9d26ad6c75b800f74d31d056286) Add note for dot1q-tunnel mode - [`a971500`](https://github.com/netbox-community/netbox/commit/a9715002a21729d83a4fd2c5c1df3f32427a2f8a) Consistent naming - [`91af48e`](https://github.com/netbox-community/netbox/commit/91af48ea80566d1366bdf1a580c74688d4506375) Update models.py - [`42b4558`](https://github.com/netbox-community/netbox/commit/42b4558210f23873e54af2c8cd5a708e9eb675c6) Update choices.py - [`1815597`](https://github.com/netbox-community/netbox/commit/1815597ece3aa05105448df1e40e8fd010843fe6) Update models.py - [`04f401c`](https://github.com/netbox-community/netbox/commit/04f401c40faf07325098a4de90d600f95f0a31ed) Update vlanTags.ts ### 📊 Changes **4 files changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/choices.py` (+2 -0) 📝 `netbox/dcim/forms/common.py` (+7 -1) 📝 `netbox/dcim/forms/models.py` (+2 -1) 📝 `netbox/project-static/src/forms/vlanTags.ts` (+1 -0) </details> ### 📄 Description ### Fixes: 116 Add 802.1ad [Q-in-Q] (https://en.wikipedia.org/wiki/IEEE_802.1ad) to Interface Types - The previous feature requests have greatly complicated this. Bare minimum needed is simply the option in InterfaceModeChoices. When an interface is in the q-in-q mode. As far as Netbox is concerned, it's a "special" access port. I'm looking for this field to use for automating switchport configuration. Yes, I can add a custom field, but this is a IEEE 802.x type, it should be an option. Below is an example of the relevant portions of a port configured for q-in-q (Cisco Catalyst switch, I'm guessing others are similar): interface GigabitEthernet1/0/11 switchport access vlan 1000 switchport mode **dot1q-tunnel** As opposed to a "tagged" port: interface TenGigabitEthernet1/1/3 switchport trunk native vlan 1001 switchport mode trunk switchport trunk allowed vlan 10,20,30,55-60 Or a "tagged-all" port: interface TenGigabitEthernet1/1/3 switchport trunk native vlan 1001 switchport mode trunk switchport trunk allowed vlan all Or an "access" port: interface TenGigabitEthernet1/1/4 switchport trunk native vlan 1002 switchport mode **access** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:18 +01:00
adam closed this issue 2025-12-29 22:26:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13260
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?