starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #7382] [MERGED] Refactor forms #13236

New Issue
Closed
opened 2025-12-29 22:26:10 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7382
Author: @jeremystretch
Created: 9/28/2021
Status: ✅ Merged
Merged: 9/28/2021
Merged by: @jeremystretch

Base: develop ← Head: refactor-forms

📝 Commits (7)

📊 Changes

51 files changed (+10481 additions, -10078 deletions)

View changed files

➖ netbox/circuits/forms.py (+0 -513)
➕ netbox/circuits/forms/__init__.py (+4 -0)
➕ netbox/circuits/forms/bulk_edit.py (+135 -0)
➕ netbox/circuits/forms/bulk_import.py (+77 -0)
➕ netbox/circuits/forms/filtersets.py (+159 -0)
➕ netbox/circuits/forms/models.py (+168 -0)
➖ netbox/dcim/forms.py (+0 -5533)
➕ netbox/dcim/forms/__init__.py (+10 -0)
➕ netbox/dcim/forms/bulk_create.py (+111 -0)
➕ netbox/dcim/forms/bulk_edit.py (+1090 -0)
➕ netbox/dcim/forms/bulk_import.py (+976 -0)
➕ netbox/dcim/forms/common.py (+49 -0)
➕ netbox/dcim/forms/connections.py (+289 -0)
➕ netbox/dcim/forms/fields.py (+25 -0)
➕ netbox/dcim/forms/filtersets.py (+1143 -0)
➕ netbox/dcim/forms/formsets.py (+21 -0)
➕ netbox/dcim/forms/models.py (+1232 -0)
➕ netbox/dcim/forms/object_create.py (+614 -0)
➕ netbox/dcim/forms/object_import.py (+148 -0)
📝 netbox/dcim/tests/test_forms.py (+1 -0)

...and 31 more files

📄 Description

Within each app, forms.py is split into separate modules, with classes grouped by function (model forms, filterset forms, bulk edit forms, etc.). This is strictly a refactoring & cleanup: no change to existing functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7382 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/28/2021 **Status:** ✅ Merged **Merged:** 9/28/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `refactor-forms` --- ### 📝 Commits (7) - [`b5aecfe`](https://github.com/netbox-community/netbox/commit/b5aecfeb91261b1b68da31cdb6dfd8533d590df5) Refactor circuits forms - [`9e2364b`](https://github.com/netbox-community/netbox/commit/9e2364b246fd059c915ecea3e8aa426454166bc4) Refactor DCIM forms - [`dba9602`](https://github.com/netbox-community/netbox/commit/dba9602c75f98a6ee1f18d6ef0129491f31f7059) Refactor tenancy forms - [`8e84956`](https://github.com/netbox-community/netbox/commit/8e849566d5cf3f7b321c5653b45d05b4c5d0c800) Refactored IPAM forms - [`db522f9`](https://github.com/netbox-community/netbox/commit/db522f96be87ee2d4a77bc1bbab5e12e2e7146b7) Refactor virtualization forms - [`833acc3`](https://github.com/netbox-community/netbox/commit/833acc3618cf24dbd5a365c619698eed6bc19a79) Refactor extras forms - [`13e9d57`](https://github.com/netbox-community/netbox/commit/13e9d57d6831fe6db1986ecc947a85288e458b9a) Merge branch 'develop' into refactor-forms ### 📊 Changes **51 files changed** (+10481 additions, -10078 deletions) <details> <summary>View changed files</summary> ➖ `netbox/circuits/forms.py` (+0 -513) ➕ `netbox/circuits/forms/__init__.py` (+4 -0) ➕ `netbox/circuits/forms/bulk_edit.py` (+135 -0) ➕ `netbox/circuits/forms/bulk_import.py` (+77 -0) ➕ `netbox/circuits/forms/filtersets.py` (+159 -0) ➕ `netbox/circuits/forms/models.py` (+168 -0) ➖ `netbox/dcim/forms.py` (+0 -5533) ➕ `netbox/dcim/forms/__init__.py` (+10 -0) ➕ `netbox/dcim/forms/bulk_create.py` (+111 -0) ➕ `netbox/dcim/forms/bulk_edit.py` (+1090 -0) ➕ `netbox/dcim/forms/bulk_import.py` (+976 -0) ➕ `netbox/dcim/forms/common.py` (+49 -0) ➕ `netbox/dcim/forms/connections.py` (+289 -0) ➕ `netbox/dcim/forms/fields.py` (+25 -0) ➕ `netbox/dcim/forms/filtersets.py` (+1143 -0) ➕ `netbox/dcim/forms/formsets.py` (+21 -0) ➕ `netbox/dcim/forms/models.py` (+1232 -0) ➕ `netbox/dcim/forms/object_create.py` (+614 -0) ➕ `netbox/dcim/forms/object_import.py` (+148 -0) 📝 `netbox/dcim/tests/test_forms.py` (+1 -0) _...and 31 more files_ </details> ### 📄 Description Within each app, `forms.py` is split into separate modules, with classes grouped by function (model forms, filterset forms, bulk edit forms, etc.). This is strictly a refactoring & cleanup: no change to existing functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:10 +01:00
adam closed this issue 2025-12-29 22:26:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?