starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #7297] [MERGED] Closes #7295: General cleanup of table classes #13228

New Issue
Closed
opened 2025-12-29 22:26:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7297
Author: @jeremystretch
Created: 9/17/2021
Status: ✅ Merged
Merged: 9/17/2021
Merged by: @jeremystretch

Base: develop ← Head: 7295-tables-cleanup

📝 Commits (3)

  • 5e29679 Merge 'detail' tables into primaries for each model
  • 9cb29f4 Use exclude() when instantiating tables to omit columns
  • 7b3f6f1 Clean up table classes

📊 Changes

18 files changed (+431 additions, -422 deletions)

View changed files

📝 netbox/circuits/tables.py (+8 -0)
📝 netbox/circuits/views.py (+3 -12)
📝 netbox/dcim/tables/devices.py (+1 -0)
📝 netbox/dcim/tables/racks.py (+2 -13)
📝 netbox/dcim/views.py (+8 -16)
📝 netbox/extras/tables.py (+13 -0)
➕ netbox/ipam/tables/__init__.py (+4 -0)
📝 netbox/ipam/tables/ip.py (+27 -322)
➕ netbox/ipam/tables/services.py (+35 -0)
➕ netbox/ipam/tables/vlans.py (+203 -0)
➕ netbox/ipam/tables/vrfs.py (+74 -0)
📝 netbox/ipam/views.py (+25 -22)
📝 netbox/netbox/constants.py (+2 -2)
📝 netbox/templates/ipam/prefix/prefixes.html (+2 -2)
📝 netbox/tenancy/tables.py (+6 -0)
📝 netbox/tenancy/views.py (+1 -3)
📝 netbox/virtualization/tables.py (+8 -21)
📝 netbox/virtualization/views.py (+9 -9)

📄 Description

Closes: #7295

  • Merge all "detail" table classes into their primaries
  • Adjust excluded columns on tables of related objects accordingly
  • Refactor IPAM tables module

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7297 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/17/2021 **Status:** ✅ Merged **Merged:** 9/17/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `7295-tables-cleanup` --- ### 📝 Commits (3) - [`5e29679`](https://github.com/netbox-community/netbox/commit/5e2967996816ed3d4e4a0dc998968f77de2dcfc6) Merge 'detail' tables into primaries for each model - [`9cb29f4`](https://github.com/netbox-community/netbox/commit/9cb29f48a0d00d63e39177ff60c65525b2cdfe6a) Use exclude() when instantiating tables to omit columns - [`7b3f6f1`](https://github.com/netbox-community/netbox/commit/7b3f6f1c673fe602530c7727c94ffbf3de0cdb08) Clean up table classes ### 📊 Changes **18 files changed** (+431 additions, -422 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/tables.py` (+8 -0) 📝 `netbox/circuits/views.py` (+3 -12) 📝 `netbox/dcim/tables/devices.py` (+1 -0) 📝 `netbox/dcim/tables/racks.py` (+2 -13) 📝 `netbox/dcim/views.py` (+8 -16) 📝 `netbox/extras/tables.py` (+13 -0) ➕ `netbox/ipam/tables/__init__.py` (+4 -0) 📝 `netbox/ipam/tables/ip.py` (+27 -322) ➕ `netbox/ipam/tables/services.py` (+35 -0) ➕ `netbox/ipam/tables/vlans.py` (+203 -0) ➕ `netbox/ipam/tables/vrfs.py` (+74 -0) 📝 `netbox/ipam/views.py` (+25 -22) 📝 `netbox/netbox/constants.py` (+2 -2) 📝 `netbox/templates/ipam/prefix/prefixes.html` (+2 -2) 📝 `netbox/tenancy/tables.py` (+6 -0) 📝 `netbox/tenancy/views.py` (+1 -3) 📝 `netbox/virtualization/tables.py` (+8 -21) 📝 `netbox/virtualization/views.py` (+9 -9) </details> ### 📄 Description Closes: #7295 - Merge all "detail" table classes into their primaries - Adjust excluded columns on tables of related objects accordingly - Refactor IPAM tables module --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:06 +01:00
adam closed this issue 2025-12-29 22:26:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?