[PR #7204] [MERGED] Verify integrity of bundled assets in CI #13219

New Issue

adam · 2025-12-29T22:26:03+01:00

adam commented

2025-12-29 22:26:03 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7204
Author: @thatmattlove
Created: 9/8/2021
Status: ✅ Merged
Merged: 9/8/2021
Merged by: @jeremystretch

Base: develop ← Head: 7202-verify-static-assets

📝 Commits (2)

9d99ede Fixes #7202: Verify integrity of bundled assets in CI
513ecd7 Merge branch 'develop' into 7202-verify-static-assets

📊 Changes

3 files changed (+46 additions, -0 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -0)
📝 docs/release-notes/version-3.0.md (+2 -0)
➕ scripts/verify-bundles.sh (+41 -0)

📄 Description

Fixes: #7202

Added a bash script to run the bundler and check for changed files via git diff. If there are any changes, produce an error.
Update CI config
Update docs

This does rely on git being available in ubuntu-latest, which I'm not 100% sure of. If it's not, we could do a shasum check of the files in netbox/project-static/dist/ before and after, but I figured this would be simpler.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7204 **Author:** [@thatmattlove](https://github.com/thatmattlove) **Created:** 9/8/2021 **Status:** ✅ Merged **Merged:** 9/8/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `7202-verify-static-assets` --- ### 📝 Commits (2) - [`9d99ede`](https://github.com/netbox-community/netbox/commit/9d99ede024218bf8d46584449e223c9e21270bca) Fixes #7202: Verify integrity of bundled assets in CI - [`513ecd7`](https://github.com/netbox-community/netbox/commit/513ecd7e2609271dcb576734d5d156677d7c75dd) Merge branch 'develop' into 7202-verify-static-assets ### 📊 Changes **3 files changed** (+46 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -0) 📝 `docs/release-notes/version-3.0.md` (+2 -0) ➕ `scripts/verify-bundles.sh` (+41 -0) </details> ### 📄 Description ### Fixes: #7202 - Added a bash script to run the bundler and check for changed files via `git diff`. If there are any changes, produce an error. - Update CI config - Update docs This _does_ rely on `git` being available in `ubuntu-latest`, which I'm not 100% sure of. If it's not, we could do a `shasum` check of the files in `netbox/project-static/dist/` before and after, but I figured this would be simpler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:26:03 +01:00

adam closed this issue

2025-12-29 22:26:03 +01:00

adam referenced this issue

2025-12-29 23:22:44 +01:00

[PR #13219] [MERGED] Closes #12194: Add pre-defined custom field choices #14134

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13219