starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 14:23:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #7024] [MERGED] Run UI Lint, Type, and Formatting Checks in Pre-Commit and CI #13199

New Issue
Closed
opened 2025-12-29 22:25:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/7024
Author: @thatmattlove
Created: 8/24/2021
Status: ✅ Merged
Merged: 8/24/2021
Merged by: @jeremystretch

Base: feature ← Head: feature-precommit-ui

📝 Commits (2)

  • 1d0c72f Add UI checks to pre-commit and CI
  • 9d0e6f0 Exclude node_modules from CI build

📊 Changes

2 files changed (+17 additions, -1 deletions)

View changed files

📝 .github/workflows/ci.yml (+11 -1)
📝 scripts/git-hooks/pre-commit (+6 -0)

📄 Description

Per internal discussions, this will ensure UI code checks are run prior to commit as well as in CI, similarly to how Python checks are run.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/7024 **Author:** [@thatmattlove](https://github.com/thatmattlove) **Created:** 8/24/2021 **Status:** ✅ Merged **Merged:** 8/24/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `feature-precommit-ui` --- ### 📝 Commits (2) - [`1d0c72f`](https://github.com/netbox-community/netbox/commit/1d0c72f5fada27b90a134aab64763610c3b8d7af) Add UI checks to pre-commit and CI - [`9d0e6f0`](https://github.com/netbox-community/netbox/commit/9d0e6f0c302efed6d892d27c460e0a142eba59b9) Exclude node_modules from CI build ### 📊 Changes **2 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+11 -1) 📝 `scripts/git-hooks/pre-commit` (+6 -0) </details> ### 📄 Description Per internal discussions, this will ensure UI code checks are run prior to commit as well as in CI, similarly to how Python checks are run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:57 +01:00
adam closed this issue 2025-12-29 22:25:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13199
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?