starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6580] [MERGED] Fixes #5442: Use LDAP groups to find permissions #13143

New Issue
Closed
opened 2025-12-29 22:25:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6580
Author: @tobiasge
Created: 6/10/2021
Status: ✅ Merged
Merged: 7/12/2021
Merged by: @jeremystretch

Base: develop ← Head: fix-5442

📝 Commits (6)

  • 8230099 Fixes #5442: Use LDAP groups to find permissions
  • 7640740 Use method from parent class
  • 5bf4234 Fix error when running scripts
  • 4abfa62 Fixed bug for users authenticated with API token
  • a3d40e3 Load LDAP groups for API token authenticated users
  • b814123 Only check REMOTE_AUTH_BACKEND in API token auth

📊 Changes

2 files changed (+36 additions, -5 deletions)

View changed files

📝 netbox/netbox/api/authentication.py (+9 -0)
📝 netbox/netbox/authentication.py (+27 -5)

📄 Description

Fixes: #5442

When AUTH_LDAP_FIND_GROUP_PERMS is set to true the filter to find the
users permissions is extended to search for all permissions assigned to
groups in which the LDAP user is.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6580 **Author:** [@tobiasge](https://github.com/tobiasge) **Created:** 6/10/2021 **Status:** ✅ Merged **Merged:** 7/12/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `fix-5442` --- ### 📝 Commits (6) - [`8230099`](https://github.com/netbox-community/netbox/commit/82300990ec79f8ce6b2fca953d5548028a14aaea) Fixes #5442: Use LDAP groups to find permissions - [`7640740`](https://github.com/netbox-community/netbox/commit/76407401130734e6d224ebbcba19182560eba794) Use method from parent class - [`5bf4234`](https://github.com/netbox-community/netbox/commit/5bf4234ad3f2d0a02a1eda37d4a196d66970a7fb) Fix error when running scripts - [`4abfa62`](https://github.com/netbox-community/netbox/commit/4abfa6231c4a5006e4baa9b3306c9307c4c75092) Fixed bug for users authenticated with API token - [`a3d40e3`](https://github.com/netbox-community/netbox/commit/a3d40e35212841bef7366953a39ff4c04e826bdd) Load LDAP groups for API token authenticated users - [`b814123`](https://github.com/netbox-community/netbox/commit/b814123ede55e2052462648cb8e409f2c7df43fa) Only check REMOTE_AUTH_BACKEND in API token auth ### 📊 Changes **2 files changed** (+36 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/api/authentication.py` (+9 -0) 📝 `netbox/netbox/authentication.py` (+27 -5) </details> ### 📄 Description ### Fixes: #5442 When AUTH_LDAP_FIND_GROUP_PERMS is set to true the filter to find the users permissions is extended to search for all permissions assigned to groups in which the LDAP user is. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:38 +01:00
adam closed this issue 2025-12-29 22:25:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13143
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?