starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6516] [MERGED] Closes #6284: Fix redundant webhooks #13134

New Issue
Closed
opened 2025-12-29 22:25:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6516
Author: @jeremystretch
Created: 6/1/2021
Status: ✅ Merged
Merged: 6/1/2021
Merged by: @jeremystretch

Base: develop ← Head: 6284-m2m-webhooks

📝 Commits (6)

📊 Changes

5 files changed (+269 additions, -62 deletions)

View changed files

📝 docs/release-notes/version-2.11.md (+1 -0)
📝 netbox/extras/context_managers.py (+9 -2)
📝 netbox/extras/signals.py (+24 -6)
📝 netbox/extras/tests/test_webhooks.py (+176 -18)
📝 netbox/extras/webhooks.py (+59 -36)

📄 Description

Fixes: #6284

Queue webhooks in memory until the request completes, updating the most recent M2M changes as necessary, then flush to RQ once all webhooks have been updated.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6516 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/1/2021 **Status:** ✅ Merged **Merged:** 6/1/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `6284-m2m-webhooks` --- ### 📝 Commits (6) - [`3d1e4fd`](https://github.com/netbox-community/netbox/commit/3d1e4fde81e0c60a0ade64f0537e94b5239f62ed) Initial work on #6284 - [`c88dcef`](https://github.com/netbox-community/netbox/commit/c88dcef900e2e7629e64412e06cf499cf3544495) Extend webhook create/update/delete tests - [`ba3ca6b`](https://github.com/netbox-community/netbox/commit/ba3ca6b00d8a1fddc9fa1d26a7dab64b708d1487) Update post-change snapshot for M2M changes - [`be3cd2a`](https://github.com/netbox-community/netbox/commit/be3cd2a4347e228511ed34054ad0513cf143d2c0) Add bulk operation tests for webhooks - [`32cbc20`](https://github.com/netbox-community/netbox/commit/32cbc201088910a774cbc9a04344937a91299a65) Restore webhooks worker test - [`8afb7d6`](https://github.com/netbox-community/netbox/commit/8afb7d654db835ed451d7a75d54b68da5a3d9b86) Changelog for #6284 ### 📊 Changes **5 files changed** (+269 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.11.md` (+1 -0) 📝 `netbox/extras/context_managers.py` (+9 -2) 📝 `netbox/extras/signals.py` (+24 -6) 📝 `netbox/extras/tests/test_webhooks.py` (+176 -18) 📝 `netbox/extras/webhooks.py` (+59 -36) </details> ### 📄 Description ### Fixes: #6284 Queue webhooks in memory until the request completes, updating the most recent M2M changes as necessary, then flush to RQ once all webhooks have been updated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:35 +01:00
adam closed this issue 2025-12-29 22:25:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?