starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6421] [MERGED] Template cleanup #13129

New Issue
Closed
opened 2025-12-29 22:25:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6421
Author: @jeremystretch
Created: 5/14/2021
Status: ✅ Merged
Merged: 5/17/2021
Merged by: @jeremystretch

Base: feature ← Head: template-cleanup

📝 Commits (10+)

  • 06b80b0 Clean up & comment base templates
  • 84c6b3c Clean up login template & form
  • 947982f Use SVG file for NetBox logo
  • cb6dbc8 Simplify breadcrumbs
  • 8545974 Merge changelog.html into home.html
  • f85d131 Rename title_container block to header
  • e0a3a9c Move breadcrumbs block to object.html
  • 0daa113 Attach names to endblock template tags
  • 47faa80 Reorganize root-level templates into base/ and inc/
  • 2250e88 Remove obsolete reference to Bootstrap 3.4.1

📊 Changes

73 files changed (+426 additions, -468 deletions)

View changed files

📝 netbox/templates/403.html (+1 -1)
📝 netbox/templates/404.html (+1 -1)
📝 netbox/templates/base/40x.html (+1 -1)
📝 netbox/templates/base/base.html (+33 -13)
➕ netbox/templates/base/layout.html (+128 -0)
➖ netbox/templates/bottom.html (+0 -16)
➖ netbox/templates/changelog.html (+0 -47)
📝 netbox/templates/dcim/cable_connect.html (+1 -1)
📝 netbox/templates/dcim/cable_trace.html (+1 -1)
📝 netbox/templates/dcim/connections_list.html (+2 -2)
📝 netbox/templates/dcim/device_component_add.html (+1 -1)
📝 netbox/templates/dcim/devicebay_populate.html (+1 -1)
📝 netbox/templates/dcim/devicetype_component_add.html (+1 -1)
📝 netbox/templates/dcim/inc/devicetype_component_table.html (+2 -2)
📝 netbox/templates/dcim/interface.html (+2 -2)
📝 netbox/templates/dcim/rack_elevation_list.html (+1 -1)
📝 netbox/templates/dcim/virtualchassis_add_member.html (+1 -1)
📝 netbox/templates/dcim/virtualchassis_edit.html (+1 -1)
📝 netbox/templates/exceptions/import_error.html (+1 -1)
📝 netbox/templates/exceptions/permission_error.html (+1 -1)

...and 53 more files

📄 Description

  • Adds comments throughout base templates for better readability (not sure why I haven't done this until now)
  • Cleans up login form
  • Use SVG file for NetBox logo (though I'm open to discussion on this)
  • Simplifies navigation breadcrumbs
  • Move breadcrumbs block to object.html
  • Reorganize root-level templates into base/ and inc/ directories

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6421 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/14/2021 **Status:** ✅ Merged **Merged:** 5/17/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `template-cleanup` --- ### 📝 Commits (10+) - [`06b80b0`](https://github.com/netbox-community/netbox/commit/06b80b060c072916384378ede56d6b9209961642) Clean up & comment base templates - [`84c6b3c`](https://github.com/netbox-community/netbox/commit/84c6b3cfda5740ae7eb1f1193175225ada54323e) Clean up login template & form - [`947982f`](https://github.com/netbox-community/netbox/commit/947982f69932c2a1193438da0ed68e2fd38b9e97) Use SVG file for NetBox logo - [`cb6dbc8`](https://github.com/netbox-community/netbox/commit/cb6dbc801fec162da8150e66fb4c755a1463f461) Simplify breadcrumbs - [`8545974`](https://github.com/netbox-community/netbox/commit/8545974e47016caa89ba5c3e2e8180ee54bb43dd) Merge changelog.html into home.html - [`f85d131`](https://github.com/netbox-community/netbox/commit/f85d131e6407f4c57f584d9a29155831146ea88b) Rename title_container block to header - [`e0a3a9c`](https://github.com/netbox-community/netbox/commit/e0a3a9cd9281fa0912f2d467e3715a397841e2e5) Move breadcrumbs block to object.html - [`0daa113`](https://github.com/netbox-community/netbox/commit/0daa1134f3daf2960865b1272ed4413be89c4b11) Attach names to endblock template tags - [`47faa80`](https://github.com/netbox-community/netbox/commit/47faa807ba8cedda08732cfd06675b8a6093595f) Reorganize root-level templates into base/ and inc/ - [`2250e88`](https://github.com/netbox-community/netbox/commit/2250e881696cebe17d62dee79e1937ee28cb2533) Remove obsolete reference to Bootstrap 3.4.1 ### 📊 Changes **73 files changed** (+426 additions, -468 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/403.html` (+1 -1) 📝 `netbox/templates/404.html` (+1 -1) 📝 `netbox/templates/base/40x.html` (+1 -1) 📝 `netbox/templates/base/base.html` (+33 -13) ➕ `netbox/templates/base/layout.html` (+128 -0) ➖ `netbox/templates/bottom.html` (+0 -16) ➖ `netbox/templates/changelog.html` (+0 -47) 📝 `netbox/templates/dcim/cable_connect.html` (+1 -1) 📝 `netbox/templates/dcim/cable_trace.html` (+1 -1) 📝 `netbox/templates/dcim/connections_list.html` (+2 -2) 📝 `netbox/templates/dcim/device_component_add.html` (+1 -1) 📝 `netbox/templates/dcim/devicebay_populate.html` (+1 -1) 📝 `netbox/templates/dcim/devicetype_component_add.html` (+1 -1) 📝 `netbox/templates/dcim/inc/devicetype_component_table.html` (+2 -2) 📝 `netbox/templates/dcim/interface.html` (+2 -2) 📝 `netbox/templates/dcim/rack_elevation_list.html` (+1 -1) 📝 `netbox/templates/dcim/virtualchassis_add_member.html` (+1 -1) 📝 `netbox/templates/dcim/virtualchassis_edit.html` (+1 -1) 📝 `netbox/templates/exceptions/import_error.html` (+1 -1) 📝 `netbox/templates/exceptions/permission_error.html` (+1 -1) _...and 53 more files_ </details> ### 📄 Description - Adds comments throughout base templates for better readability (not sure why I haven't done this until now) - Cleans up login form - Use SVG file for NetBox logo (though I'm open to discussion on this) - Simplifies navigation breadcrumbs - Move `breadcrumbs` block to `object.html` - Reorganize root-level templates into `base/` and `inc/` directories --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:34 +01:00
adam closed this issue 2025-12-29 22:25:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13129
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?