[PR #6449] [MERGED] Fixed #6438 Device Type Import does not import/export description/label fields for many components #13128

New Issue

adam · 2025-12-29T22:25:34+01:00

adam commented

2025-12-29 22:25:34 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6449
Author: @991jo
Created: 5/20/2021
Status: ✅ Merged
Merged: 5/21/2021
Merged by: @jeremystretch

Base: develop ← Head: device_type_import_fix

📝 Commits (1)

ea6c8a1 Fixed #6438 Device Type Import does not import/export description/label fields for many components

📊 Changes

3 files changed (+25 additions, -8 deletions)

View changed files

📝 docs/release-notes/version-2.11.md (+1 -0)
📝 netbox/dcim/forms.py (+8 -8)
📝 netbox/dcim/models/devices.py (+16 -0)

📄 Description

Fixes: #6438

Some Components of Device Types did not import and export their label and/or description fields.

I fixed it by adding the fields to the appropriate lists where needed.

A less redundant solution could be to only have the list of fields in the ImportForms and iterate over the Meta.fields attribute of the ImportForms in the export function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6449 **Author:** [@991jo](https://github.com/991jo) **Created:** 5/20/2021 **Status:** ✅ Merged **Merged:** 5/21/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `device_type_import_fix` --- ### 📝 Commits (1) - [`ea6c8a1`](https://github.com/netbox-community/netbox/commit/ea6c8a1a65f2db8a6ff6937a83fb90726954ec5e) Fixed #6438 Device Type Import does not import/export description/label fields for many components ### 📊 Changes **3 files changed** (+25 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.11.md` (+1 -0) 📝 `netbox/dcim/forms.py` (+8 -8) 📝 `netbox/dcim/models/devices.py` (+16 -0) </details> ### 📄 Description  ### Fixes: #6438  Some Components of Device Types did not import and export their label and/or description fields. I fixed it by adding the fields to the appropriate lists where needed. A less redundant solution could be to only have the list of fields in the ImportForms and iterate over the Meta.fields attribute of the ImportForms in the export function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:25:34 +01:00

adam closed this issue

2025-12-29 22:25:34 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13128