starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6397] [MERGED] Closes: #5278 - Remove Secrets #13124

New Issue
Closed
opened 2025-12-29 22:25:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6397
Author: @DanSheps
Created: 5/12/2021
Status: ✅ Merged
Merged: 5/17/2021
Merged by: @jeremystretch

Base: feature ← Head: 5278-remove-secrets

📝 Commits (7)

📊 Changes

97 files changed (+36 additions, -3732 deletions)

View changed files

📝 docs/administration/netbox-shell.md (+1 -1)
📝 docs/configuration/optional-settings.md (+1 -1)
➖ docs/core-functionality/secrets.md (+0 -8)
📝 docs/development/index.md (+0 -1)
📝 docs/development/models.md (+0 -2)
📝 docs/models/dcim/virtualchassis.md (+1 -1)
➖ docs/models/secrets/secret.md (+0 -5)
➖ docs/models/secrets/secretrole.md (+0 -9)
➖ docs/models/secrets/userkey.md (+0 -35)
📝 docs/rest-api/overview.md (+1 -1)
➖ docs/rest-api/working-with-secrets.md (+0 -172)
📝 mkdocs.yml (+0 -2)
📝 netbox/dcim/models/devices.py (+0 -6)
📝 netbox/dcim/views.py (+0 -5)
📝 netbox/extras/management/commands/nbshell.py (+1 -1)
📝 netbox/extras/migrations/0020_tag_data.py (+0 -1)
📝 netbox/extras/migrations/0036_contenttype_filters_to_q_objects.py (+4 -4)
📝 netbox/extras/migrations/0051_migrate_customfields.py (+0 -1)
📝 netbox/netbox/api/views.py (+0 -1)
📝 netbox/netbox/configuration.example.py (+1 -1)

...and 77 more files

📄 Description

Closes: #5278

Removes secrets from feature branch

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6397 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 5/12/2021 **Status:** ✅ Merged **Merged:** 5/17/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `5278-remove-secrets` --- ### 📝 Commits (7) - [`2081567`](https://github.com/netbox-community/netbox/commit/20815673a2164b6d4c0b0db8cd592de627347a82) Remove Secrets - [`8e2a788`](https://github.com/netbox-community/netbox/commit/8e2a7882e794efd6db2c9b943bf1c1ceae0386b4) #5278: Remove secrets javascript from netbox core - [`4a0942a`](https://github.com/netbox-community/netbox/commit/4a0942ab4ab937c0439214f2b809ab374707a1c2) Remove userkey references - [`cd4b10a`](https://github.com/netbox-community/netbox/commit/cd4b10a3ee74129deb5686b899f7d41b7d6221c5) Fix PEP8 - [`d86856e`](https://github.com/netbox-community/netbox/commit/d86856e5464dc64e249d88773de644898b096718) Merge branch 'feature' into 5278-remove-secrets - [`9c89ecb`](https://github.com/netbox-community/netbox/commit/9c89ecb762fb5157c3ca62d53d098eec5913e8f6) Remove a few more instances of secrets. Rebundle - [`33ae800`](https://github.com/netbox-community/netbox/commit/33ae800df424c2ebdbda821b5ffbf2c66a68a5d3) Remove Secrets ### 📊 Changes **97 files changed** (+36 additions, -3732 deletions) <details> <summary>View changed files</summary> 📝 `docs/administration/netbox-shell.md` (+1 -1) 📝 `docs/configuration/optional-settings.md` (+1 -1) ➖ `docs/core-functionality/secrets.md` (+0 -8) 📝 `docs/development/index.md` (+0 -1) 📝 `docs/development/models.md` (+0 -2) 📝 `docs/models/dcim/virtualchassis.md` (+1 -1) ➖ `docs/models/secrets/secret.md` (+0 -5) ➖ `docs/models/secrets/secretrole.md` (+0 -9) ➖ `docs/models/secrets/userkey.md` (+0 -35) 📝 `docs/rest-api/overview.md` (+1 -1) ➖ `docs/rest-api/working-with-secrets.md` (+0 -172) 📝 `mkdocs.yml` (+0 -2) 📝 `netbox/dcim/models/devices.py` (+0 -6) 📝 `netbox/dcim/views.py` (+0 -5) 📝 `netbox/extras/management/commands/nbshell.py` (+1 -1) 📝 `netbox/extras/migrations/0020_tag_data.py` (+0 -1) 📝 `netbox/extras/migrations/0036_contenttype_filters_to_q_objects.py` (+4 -4) 📝 `netbox/extras/migrations/0051_migrate_customfields.py` (+0 -1) 📝 `netbox/netbox/api/views.py` (+0 -1) 📝 `netbox/netbox/configuration.example.py` (+1 -1) _...and 77 more files_ </details> ### 📄 Description ### Closes: #5278 Removes secrets from feature branch --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:32 +01:00
adam closed this issue 2025-12-29 22:25:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13124
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?