starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6323] [MERGED] Closes #2434: Show 'Create & Assign IP Address' Button when Creating … #13117

New Issue
Closed
opened 2025-12-29 22:25:30 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6323
Author: @thatmattlove
Created: 4/30/2021
Status: ✅ Merged
Merged: 5/14/2021
Merged by: @jeremystretch

Base: feature ← Head: feature-2434

📝 Commits (10+)

  • de56e2b Closes #2434: Show 'Create & Assign IP Address' Button when Creating Interfaces
  • 04cc43b ensure 'Create & Assign IP Address' button is only shown when the component_type is 'interface'
  • 515aed7 Merge branch 'feature' into feature-2434
  • 2d2719c #2434: Refactor ComponentCreateView to use generic form validation method
  • 3436780 #6372: Show standard form validation errors
  • b9a413d #2434: Fix redirection logic in generic form validation method
  • 892d121 Merge branch 'feature' into feature-2434
  • 8056290 #2434: Apply conditional logic from b9a413d to overridden InterfaceCreateView.post method
  • 7d7d066 Merge branch 'feature' of github.com:netbox-community/netbox into feature
  • 234475e Merge branch 'feature' into feature-2434

📊 Changes

4 files changed (+94 additions, -60 deletions)

View changed files

📝 netbox/dcim/views.py (+27 -0)
📝 netbox/netbox/views/generic.py (+30 -18)
📝 netbox/templates/dcim/device_component_add.html (+5 -0)
📝 netbox/templates/messages.html (+32 -42)

📄 Description

Fixes: #2434

Changes

  • Show a 'Create & Assign IP Address' button, permissions permitting
  • Handle _assignip form field (set by above button) by choosing first created object and redirecting the user to the Create IP Address View with the newly created object pre-populated.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6323 **Author:** [@thatmattlove](https://github.com/thatmattlove) **Created:** 4/30/2021 **Status:** ✅ Merged **Merged:** 5/14/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `feature-2434` --- ### 📝 Commits (10+) - [`de56e2b`](https://github.com/netbox-community/netbox/commit/de56e2b405627e47c4fcfe1565a5ea93a1abfe99) Closes #2434: Show 'Create & Assign IP Address' Button when Creating Interfaces - [`04cc43b`](https://github.com/netbox-community/netbox/commit/04cc43b2f0858a1f3fb7044a58e4fd33976d8f56) ensure 'Create & Assign IP Address' button is only shown when the component_type is 'interface' - [`515aed7`](https://github.com/netbox-community/netbox/commit/515aed7022a9c5fa2b3eea5dc7bbfb16daf6ff26) Merge branch 'feature' into feature-2434 - [`2d2719c`](https://github.com/netbox-community/netbox/commit/2d2719cfb23663619b6f734a986247bc8b7bf74b) #2434: Refactor ComponentCreateView to use generic form validation method - [`3436780`](https://github.com/netbox-community/netbox/commit/3436780117b94fba825b29eab9f0a00be65c558c) #6372: Show standard form validation errors - [`b9a413d`](https://github.com/netbox-community/netbox/commit/b9a413d19e6e5bfb9556e1bcc1db6542314c9eb2) #2434: Fix redirection logic in generic form validation method - [`892d121`](https://github.com/netbox-community/netbox/commit/892d1214b0176bae322a9b756d8dc730ff889d17) Merge branch 'feature' into feature-2434 - [`8056290`](https://github.com/netbox-community/netbox/commit/8056290423d5f8b1d11a665592cd08c5f0fca9e0) #2434: Apply conditional logic from b9a413d to overridden InterfaceCreateView.post method - [`7d7d066`](https://github.com/netbox-community/netbox/commit/7d7d06651c40c872fcdbe4bcf0dcb2775dbcb817) Merge branch 'feature' of github.com:netbox-community/netbox into feature - [`234475e`](https://github.com/netbox-community/netbox/commit/234475effea93b7407772a2dd6e8b25cc433302e) Merge branch 'feature' into feature-2434 ### 📊 Changes **4 files changed** (+94 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+27 -0) 📝 `netbox/netbox/views/generic.py` (+30 -18) 📝 `netbox/templates/dcim/device_component_add.html` (+5 -0) 📝 `netbox/templates/messages.html` (+32 -42) </details> ### 📄 Description ### Fixes: #2434 #### Changes - Show a 'Create & Assign IP Address' button, permissions permitting - Handle `_assignip` form field (set by above button) by choosing first created object and redirecting the user to the Create IP Address View with the newly created object pre-populated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:30 +01:00
adam closed this issue 2025-12-29 22:25:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13117
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?