starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6316] [CLOSED] Closes #2434: Show 'Create & Assign IP Address' Button when Creating Interfaces #13113

New Issue
Closed
opened 2025-12-29 22:25:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6316
Author: @thatmattlove
Created: 4/30/2021
Status: ❌ Closed

Base: feature ← Head: feature

📝 Commits (4)

  • 3561cec Closes #2434: Added 'Create & Assign IP Address' button when adding an interface
  • e9b0707 fix various style issues
  • f9d43bc fix api select pagination
  • 2422785 general style improvements

📊 Changes

13 files changed (+123 additions, -14 deletions)

View changed files

📝 netbox/dcim/views.py (+70 -0)
📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/dist/netbox.css.map (+1 -1)
📝 netbox/project-static/dist/netbox.js (+1 -1)
📝 netbox/project-static/dist/netbox.js.map (+1 -1)
📝 netbox/project-static/dist/rack_elevation.css.map (+1 -1)
📝 netbox/project-static/netbox.scss (+24 -4)
📝 netbox/project-static/select.scss (+7 -0)
📝 netbox/project-static/src/select/api.ts (+1 -1)
📝 netbox/project-static/theme-base.scss (+7 -0)
📝 netbox/project-static/theme-dark.scss (+2 -2)
📝 netbox/templates/dcim/device_component_add.html (+5 -0)
📝 netbox/templates/utilities/confirmation_form.html (+2 -2)

📄 Description

Fixes: #2434

#2434 Changes:

  • Show a 'Create & Assign IP Address' button, permissions permitting
  • Handle _assignip form field (set by above button) by choosing first created object and redirecting the user to the Create IP Address View with the newly created object pre-populated.

UI Changes:

  • Fix an issue in dark mode where object deletion confirmation buttons were the wrong color.
  • Fix an issue in dark mode where select elements' search input fields' color was the wrong color.
  • Set the $link-hover-color Sass variable in dark mode so <a/> tags are lightened on hover instead of darkened.
  • Fix an issue where API-backed select elements used the default pagination limit of 50 objects, causing incomplete data and predefined selections not to work properly.
  • Set smaller table padding-x and font-size so that table data fits a little better in the viewport.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6316 **Author:** [@thatmattlove](https://github.com/thatmattlove) **Created:** 4/30/2021 **Status:** ❌ Closed **Base:** `feature` ← **Head:** `feature` --- ### 📝 Commits (4) - [`3561cec`](https://github.com/netbox-community/netbox/commit/3561cec51f9d6464a58bf88663556b5bcf857185) Closes #2434: Added 'Create & Assign IP Address' button when adding an interface - [`e9b0707`](https://github.com/netbox-community/netbox/commit/e9b0707500ebb6484d52ac2319fd7b805bc09211) fix various style issues - [`f9d43bc`](https://github.com/netbox-community/netbox/commit/f9d43bcb465067a08b65a7f0d310fdc19e6a261e) fix api select pagination - [`2422785`](https://github.com/netbox-community/netbox/commit/2422785ab1b0cccac6f14f3e92859d93168adbcb) general style improvements ### 📊 Changes **13 files changed** (+123 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+70 -0) 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/dist/netbox.css.map` (+1 -1) 📝 `netbox/project-static/dist/netbox.js` (+1 -1) 📝 `netbox/project-static/dist/netbox.js.map` (+1 -1) 📝 `netbox/project-static/dist/rack_elevation.css.map` (+1 -1) 📝 `netbox/project-static/netbox.scss` (+24 -4) 📝 `netbox/project-static/select.scss` (+7 -0) 📝 `netbox/project-static/src/select/api.ts` (+1 -1) 📝 `netbox/project-static/theme-base.scss` (+7 -0) 📝 `netbox/project-static/theme-dark.scss` (+2 -2) 📝 `netbox/templates/dcim/device_component_add.html` (+5 -0) 📝 `netbox/templates/utilities/confirmation_form.html` (+2 -2) </details> ### 📄 Description ### Fixes: #2434 #### #2434 Changes: - Show a 'Create & Assign IP Address' button, permissions permitting - Handle `_assignip` form field (set by above button) by choosing first created object and redirecting the user to the Create IP Address View with the newly created object pre-populated. #### UI Changes: - Fix an issue in dark mode where object deletion confirmation buttons were the wrong color. - Fix an issue in dark mode where select elements' search input fields' color was the wrong color. - Set the `$link-hover-color` Sass variable in dark mode so `<a/>` tags are lightened on hover instead of darkened. - Fix an issue where API-backed select elements used the default pagination limit of 50 objects, causing incomplete data and predefined selections not to work properly. - Set smaller table padding-x and font-size so that table data fits a little better in the viewport. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:29 +01:00
adam closed this issue 2025-12-29 22:25:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?