[PR #6072] [MERGED] #5830: Expand ExportTemplate model with attachment choice #13094

Closed
opened 2025-12-29 22:25:22 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6072
Author: @rodvand
Created: 3/30/2021
Status: Merged
Merged: 3/31/2021
Merged by: @jeremystretch

Base: featureHead: origin/feature


📝 Commits (2)

  • 9ede726 Add boolean as_attachment to Export template
  • 878154c Closes #5830: Add as_attachment field to API serializers and admin view.

📊 Changes

4 files changed (+28 additions, -4 deletions)

View changed files

📝 netbox/extras/admin.py (+2 -2)
📝 netbox/extras/api/serializers.py (+1 -1)
netbox/extras/migrations/0059_attachment_export_templates.py (+18 -0)
📝 netbox/extras/models/models.py (+7 -1)

📄 Description

Fixes: #5830

Expand ExportTemplate model with the Boolean as_attachment to allow the user to not require a local download of the export template. Instead, with as_attachment unchecked, the export template is presented directly in the user's browser.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6072 **Author:** [@rodvand](https://github.com/rodvand) **Created:** 3/30/2021 **Status:** ✅ Merged **Merged:** 3/31/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `origin/feature` --- ### 📝 Commits (2) - [`9ede726`](https://github.com/netbox-community/netbox/commit/9ede726eea108e63e0c1ec7af21148ce18c875cc) Add boolean as_attachment to Export template - [`878154c`](https://github.com/netbox-community/netbox/commit/878154c305f6ad99e0810824f5aa0706ebb9610c) Closes #5830: Add as_attachment field to API serializers and admin view. ### 📊 Changes **4 files changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/admin.py` (+2 -2) 📝 `netbox/extras/api/serializers.py` (+1 -1) ➕ `netbox/extras/migrations/0059_attachment_export_templates.py` (+18 -0) 📝 `netbox/extras/models/models.py` (+7 -1) </details> ### 📄 Description ### Fixes: #5830 Expand ExportTemplate model with the Boolean as_attachment to allow the user to not require a local download of the export template. Instead, with as_attachment unchecked, the export template is presented directly in the user's browser. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:22 +01:00
adam closed this issue 2025-12-29 22:25:22 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13094