starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5985] [MERGED] Closes #5284: Allow VLANGroup assignment beyond sites #13079

New Issue
Closed
opened 2025-12-29 22:25:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5985
Author: @jeremystretch
Created: 3/15/2021
Status: ✅ Merged
Merged: 3/16/2021
Merged by: @jeremystretch

Base: feature ← Head: 5284-vlangroup-scope

📝 Commits (10+)

📊 Changes

13 files changed (+427 additions, -143 deletions)

View changed files

📝 docs/release-notes/version-2.11.md (+9 -0)
📝 netbox/ipam/api/serializers.py (+18 -3)
📝 netbox/ipam/api/views.py (+1 -1)
📝 netbox/ipam/filters.py (+26 -33)
📝 netbox/ipam/forms.py (+119 -35)
➕ netbox/ipam/migrations/0045_vlangroup_scope.py (+36 -0)
📝 netbox/ipam/models/vlans.py (+35 -12)
📝 netbox/ipam/tables.py (+4 -4)
📝 netbox/ipam/tests/test_filters.py (+57 -45)
📝 netbox/ipam/tests/test_views.py (+11 -7)
📝 netbox/ipam/views.py (+5 -3)
➕ netbox/templates/ipam/vlan_edit.html (+57 -0)
➕ netbox/templates/ipam/vlangroup_edit.html (+49 -0)

📄 Description

Closes: #5284

  • Introduce the scope generic foreign key on VLANGroup
  • Remove the site field from VLANGroup (preserve all existing assignments via scope)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5985 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 3/15/2021 **Status:** ✅ Merged **Merged:** 3/16/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `5284-vlangroup-scope` --- ### 📝 Commits (10+) - [`4dae781`](https://github.com/netbox-community/netbox/commit/4dae781be0a8f6aae995681cb93f25550b192379) Change VLANGroup site to scope (GFK) - [`653af17`](https://github.com/netbox-community/netbox/commit/653af17755241f570e0980d5a7e813a687ea7508) Merge branch 'feature' into 5284-vlangroup-scope - [`f4e4949`](https://github.com/netbox-community/netbox/commit/f4e49495e2d2a73ecd0d94d359d28357bb038334) Merge branch 'feature' into 5284-vlangroup-scope - [`d3fee54`](https://github.com/netbox-community/netbox/commit/d3fee54644bd44b8b282101b04b2258148ff3084) Fix VLAN.clean() - [`6ab1c06`](https://github.com/netbox-community/netbox/commit/6ab1c060368403baa29a0bee73394f10eb0ccd3d) Extend VLAN group assignment form - [`fadf15d`](https://github.com/netbox-community/netbox/commit/fadf15dbc0cfd3d8eae6e17bde5ec6c0787c045d) Fix VLAN group assignment for VLANs - [`0115a61`](https://github.com/netbox-community/netbox/commit/0115a61ab7eea34439bdee1a15d10ca610f4d866) Add changelog for #5284 - [`c0c4eed`](https://github.com/netbox-community/netbox/commit/c0c4eed3a85964bce9427d556496a6391fedf4b8) Extend VLANGroup to support cluster/cluster group assignment - [`bb6360c`](https://github.com/netbox-community/netbox/commit/bb6360cad4f2a99474892034d614ea16aa68d2b6) Fix up VLANGroup tests - [`10778f8`](https://github.com/netbox-community/netbox/commit/10778f84798005a49a254952f23638bb57721810) Merge branch 'feature' into 5284-vlangroup-scope ### 📊 Changes **13 files changed** (+427 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.11.md` (+9 -0) 📝 `netbox/ipam/api/serializers.py` (+18 -3) 📝 `netbox/ipam/api/views.py` (+1 -1) 📝 `netbox/ipam/filters.py` (+26 -33) 📝 `netbox/ipam/forms.py` (+119 -35) ➕ `netbox/ipam/migrations/0045_vlangroup_scope.py` (+36 -0) 📝 `netbox/ipam/models/vlans.py` (+35 -12) 📝 `netbox/ipam/tables.py` (+4 -4) 📝 `netbox/ipam/tests/test_filters.py` (+57 -45) 📝 `netbox/ipam/tests/test_views.py` (+11 -7) 📝 `netbox/ipam/views.py` (+5 -3) ➕ `netbox/templates/ipam/vlan_edit.html` (+57 -0) ➕ `netbox/templates/ipam/vlangroup_edit.html` (+49 -0) </details> ### 📄 Description ### Closes: #5284 - Introduce the `scope` generic foreign key on VLANGroup - Remove the `site` field from VLANGroup (preserve all existing assignments via `scope`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:17 +01:00
adam closed this issue 2025-12-29 22:25:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?