starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add Tenant ownership to Rack Reservations #1307

New Issue
Closed
opened 2025-12-29 16:31:17 +01:00 by adam · 7 comments
adam commented 2025-12-29 16:31:17 +01:00
Owner
Copy Link

Originally created by @dirtycajunrice on GitHub (Oct 13, 2017).

Issue type

[x] Feature request
[ ] Bug report
[ ] Documentation

Description

I propose an addition to the rack reservation table that allows association with a Tenant (Exactly like IP addresses) which would allow racks used for "Shared Colocation Environments" to have the ability to reserve less than an entire rack for a customer. E.g. 7-8U per customer.

This would not matter if they were managed as devices are able to be assigned. But for environments where you only are keeping track of what section you have assigned the Tenant, it would be very helpful.

Originally created by @dirtycajunrice on GitHub (Oct 13, 2017). ### Issue type [x] Feature request <!-- Requesting the implementation of a new feature --> [ ] Bug report <!-- Reporting unexpected or erroneous behavior --> [ ] Documentation <!-- Proposing a modification to the documentation --> ### Description I propose an addition to the rack reservation table that allows association with a Tenant (Exactly like IP addresses) which would allow racks used for "Shared Colocation Environments" to have the ability to reserve less than an entire rack for a customer. E.g. 7-8U per customer. This would not matter if they were managed as devices are able to be assigned. But for environments where you only are keeping track of what section you have assigned the Tenant, it would be very helpful.
adam added the type: feature label 2025-12-29 16:31:17 +01:00
adam closed this issue 2025-12-29 16:31:17 +01:00
adam commented 2025-12-29 16:31:18 +01:00
Author
Owner
Copy Link

@dirtycajunrice commented on GitHub (Oct 30, 2017):

I am comfortable enough with python to make these changes myself but I do need a point in the right direction for files, to begin with. Much appreciated

@dirtycajunrice commented on GitHub (Oct 30, 2017): I am comfortable enough with python to make these changes myself but I do need a point in the right direction for files, to begin with. Much appreciated
adam commented 2025-12-29 16:31:18 +01:00
Author
Owner
Copy Link

@RyanBreaker commented on GitHub (Oct 30, 2017):

@DirtyCajunRice Start by looking in the dcim directory and the models and everything to work on this should be in there.

Sent with GitHawk

@RyanBreaker commented on GitHub (Oct 30, 2017): @DirtyCajunRice Start by looking in the `dcim` directory and the models and everything to work on this should be in there. <sub>Sent with <a href="http://githawk.com">GitHawk</a></sub>
adam commented 2025-12-29 16:31:18 +01:00
Author
Owner
Copy Link

@dirtycajunrice commented on GitHub (Oct 30, 2017):

@RyanBreaker I have the tenants showing up as an option in the reservation_add, and the tenant showing up as part of the visible table when looking at a rack, but when you look at the main rack reservations page (BulkDeleteView) it is empty. Any ideas?
https://github.com/DirtyCajunRice/netbox

@dirtycajunrice commented on GitHub (Oct 30, 2017): @RyanBreaker I have the tenants showing up as an option in the reservation_add, and the tenant showing up as part of the visible table when looking at a rack, but when you look at the main rack reservations page (BulkDeleteView) it is empty. Any ideas? https://github.com/DirtyCajunRice/netbox
adam commented 2025-12-29 16:31:19 +01:00
Author
Owner
Copy Link

@dirtycajunrice commented on GitHub (Oct 30, 2017):

ok figured that part out. Just need to figure out showing tenancy enumeration in the search box and a new box in the tenant main page

@dirtycajunrice commented on GitHub (Oct 30, 2017): ok figured that part out. Just need to figure out showing tenancy enumeration in the search box and a new box in the tenant main page
adam commented 2025-12-29 16:31:19 +01:00
Author
Owner
Copy Link

@dirtycajunrice commented on GitHub (Oct 31, 2017):

Ok, I have added the box to the tenant page as well and it is propagating properly. All that is left to figure out the tenancy enumeration in the FilterForm. Some help would be much appreciated.

@dirtycajunrice commented on GitHub (Oct 31, 2017): Ok, I have added the box to the tenant page as well and it is propagating properly. All that is left to figure out the tenancy enumeration in the FilterForm. Some help would be much appreciated.
adam commented 2025-12-29 16:31:19 +01:00
Author
Owner
Copy Link

@dirtycajunrice commented on GitHub (Oct 31, 2017):

@jeremystretch Sorry to ping you I would just love to make this pull request.
In netbox/dcim/forms.py under
class RackReservationFilterForm(BootstrapMixin, forms.Form):
the queryset for tenant currently is
queryset=Tenant.objects.annotate(filter_count=Count('racks__reservations'))
Am i missing something to make this query rack reservation ownership instead of rack ownership?

@dirtycajunrice commented on GitHub (Oct 31, 2017): @jeremystretch Sorry to ping you I would just love to make this pull request. In netbox/dcim/forms.py under `class RackReservationFilterForm(BootstrapMixin, forms.Form):` the queryset for tenant currently is `queryset=Tenant.objects.annotate(filter_count=Count('racks__reservations'))` Am i missing something to make this query rack reservation ownership instead of rack ownership?
adam commented 2025-12-29 16:31:19 +01:00
Author
Owner
Copy Link

@dirtycajunrice commented on GitHub (Nov 8, 2017):

@jeremystretch Tag 2.3?

@dirtycajunrice commented on GitHub (Nov 8, 2017): @jeremystretch Tag 2.3?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1307
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?