starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5761] [MERGED] Fixes #5735: enforcement of duplicate IP address detection with roles #13056

New Issue
Closed
opened 2025-12-29 22:25:10 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5761
Author: @candlerb
Created: 2/7/2021
Status: ✅ Merged
Merged: 2/8/2021
Merged by: @jeremystretch

Base: develop ← Head: candlerb/5735

📝 Commits (1)

  • 713f02c Fixes #5735: enforcement of duplicate IP address detection with roles

📊 Changes

2 files changed (+17 additions, -6 deletions)

View changed files

📝 netbox/ipam/models.py (+5 -6)
📝 netbox/ipam/tests/test_models.py (+12 -0)

📄 Description

Fixes: #5735

Duplicate IP detection with IPADDRESS_ROLES_NONUNIQUE was broken.

Update logic so that when validating an address, fail the uniqueness check unless this address and all its duplicates have IPADDRESS_ROLES_NONUNIQUE.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5761 **Author:** [@candlerb](https://github.com/candlerb) **Created:** 2/7/2021 **Status:** ✅ Merged **Merged:** 2/8/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `candlerb/5735` --- ### 📝 Commits (1) - [`713f02c`](https://github.com/netbox-community/netbox/commit/713f02ca3fe7d05a005ef8f0975c62f6bb812052) Fixes #5735: enforcement of duplicate IP address detection with roles ### 📊 Changes **2 files changed** (+17 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/models.py` (+5 -6) 📝 `netbox/ipam/tests/test_models.py` (+12 -0) </details> ### 📄 Description ### Fixes: #5735 Duplicate IP detection with `IPADDRESS_ROLES_NONUNIQUE` was broken. Update logic so that when validating an address, fail the uniqueness check unless this address *and* all its duplicates have `IPADDRESS_ROLES_NONUNIQUE`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:10 +01:00
adam closed this issue 2025-12-29 22:25:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13056
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?