starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5704] [MERGED] Fixes: #5315 - Make "null_option" on DynamicModelChoiceField also null the value on the model. #13053

New Issue
Closed
opened 2025-12-29 22:25:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5704
Author: @DanSheps
Created: 1/27/2021
Status: ✅ Merged
Merged: 2/12/2021
Merged by: @DanSheps

Base: develop ← Head: 5315-site_unassignment_vlan

📝 Commits (5)

  • 0f0010b Fixes: #5315 - Make "null_option" on DynamicModelChoiceField also null the value on the model.
  • ff24bb0 Update fields.py
  • 0f964ad Adjust check for FILTERS_NULL_CHOICE_VALUE
  • 7b5b119 Update fields.py
  • 20661b2 Merge branch 'develop' into 5315-site_unassignment_vlan

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 docs/release-notes/version-2.10.md (+1 -0)
📝 netbox/utilities/forms/fields.py (+10 -1)

📄 Description

Fixes: #5315

Alter the DynamicModelChoiceField to remove any value that is a string of 'null' if the 'null_option' and then call the parent clean() method.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5704 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 1/27/2021 **Status:** ✅ Merged **Merged:** 2/12/2021 **Merged by:** [@DanSheps](https://github.com/DanSheps) **Base:** `develop` ← **Head:** `5315-site_unassignment_vlan` --- ### 📝 Commits (5) - [`0f0010b`](https://github.com/netbox-community/netbox/commit/0f0010bac0855e146f21522be94fa9148d7220e3) Fixes: #5315 - Make "null_option" on DynamicModelChoiceField also null the value on the model. - [`ff24bb0`](https://github.com/netbox-community/netbox/commit/ff24bb09afec41348c91c7c33912287069b5882e) Update fields.py - [`0f964ad`](https://github.com/netbox-community/netbox/commit/0f964addf9f97bdbfb55b8a9426a40d9e7357ee4) Adjust check for FILTERS_NULL_CHOICE_VALUE - [`7b5b119`](https://github.com/netbox-community/netbox/commit/7b5b1197f815607a38e31b92ced6c2a13e243726) Update fields.py - [`20661b2`](https://github.com/netbox-community/netbox/commit/20661b2444692f66830c1ea74ed4f9ce67b5d43a) Merge branch 'develop' into 5315-site_unassignment_vlan ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.10.md` (+1 -0) 📝 `netbox/utilities/forms/fields.py` (+10 -1) </details> ### 📄 Description ### Fixes: #5315 Alter the DynamicModelChoiceField to remove any value that is a string of 'null' if the 'null_option' and then call the parent clean() method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:09 +01:00
adam closed this issue 2025-12-29 22:25:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13053
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?