starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5464] [MERGED] Fixes #5450 #13026

New Issue
Closed
opened 2025-12-29 22:25:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5464
Author: @DanSheps
Created: 12/15/2020
Status: ✅ Merged
Merged: 12/15/2020
Merged by: @DanSheps

Base: develop ← Head: 5450-api-serializer-count-fields

📝 Commits (4)

  • beeb6b5 Fixes: #5450 - Change all count and count serializers to have default value
  • 7803972 Fixes: #5450 - Added Coalesce to viewsets for the _count functions
  • f12f9f9 Final fix for null values on count items.
  • 8e3b3f8 Merge branch 'develop' into 5450-api-serializer-count-fields

📊 Changes

8 files changed (+49 additions, -41 deletions)

View changed files

📝 docs/release-notes/version-2.10.md (+1 -0)
📝 netbox/circuits/api/views.py (+3 -2)
📝 netbox/dcim/api/views.py (+20 -19)
📝 netbox/extras/api/views.py (+2 -1)
📝 netbox/ipam/api/views.py (+8 -7)
📝 netbox/secrets/api/views.py (+2 -1)
📝 netbox/tenancy/api/views.py (+8 -7)
📝 netbox/virtualization/api/views.py (+5 -4)

📄 Description

Fixes: #5450

Add Coalesce to get_subquery for *_count on serializers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5464 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 12/15/2020 **Status:** ✅ Merged **Merged:** 12/15/2020 **Merged by:** [@DanSheps](https://github.com/DanSheps) **Base:** `develop` ← **Head:** `5450-api-serializer-count-fields` --- ### 📝 Commits (4) - [`beeb6b5`](https://github.com/netbox-community/netbox/commit/beeb6b5946fec1c01bc6f5c47d24e4318f86cf89) Fixes: #5450 - Change all *_count and count_* serializers to have default value - [`7803972`](https://github.com/netbox-community/netbox/commit/7803972ee094e58d5ad64fe77fd15f3ed117ebcb) Fixes: #5450 - Added Coalesce to viewsets for the _count functions - [`f12f9f9`](https://github.com/netbox-community/netbox/commit/f12f9f92daf863184dbf0e0765dd988c0f1c5666) Final fix for null values on count items. - [`8e3b3f8`](https://github.com/netbox-community/netbox/commit/8e3b3f8c21f5228ca8cabc7bff53bd9584a2bdba) Merge branch 'develop' into 5450-api-serializer-count-fields ### 📊 Changes **8 files changed** (+49 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.10.md` (+1 -0) 📝 `netbox/circuits/api/views.py` (+3 -2) 📝 `netbox/dcim/api/views.py` (+20 -19) 📝 `netbox/extras/api/views.py` (+2 -1) 📝 `netbox/ipam/api/views.py` (+8 -7) 📝 `netbox/secrets/api/views.py` (+2 -1) 📝 `netbox/tenancy/api/views.py` (+8 -7) 📝 `netbox/virtualization/api/views.py` (+5 -4) </details> ### 📄 Description ### Fixes: #5450 Add Coalesce to get_subquery for *_count on serializers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:00 +01:00
adam closed this issue 2025-12-29 22:25:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13026
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?