starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5434] [CLOSED] Added rack_elevation.show_images to user.preferences #13019

New Issue
Closed
opened 2025-12-29 22:24:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5434
Author: @ogorov
Created: 12/9/2020
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (8)

  • a4c25e8 Added rack_elevation.show_images to user.preferences
  • a0e62c6 Merge branch 'develop' into develop-2.10
  • 8280b66 Fixes with new API endpoint
  • 8de4cbb Merge remote-tracking branch 'True-NetBox/develop' into develop-2.10
  • 437fae4 Add exception type for try catch of api method
  • 5ca574d Fix exceptions in API
  • 58c06aa Fixes for anonimous user
  • c326483 Fix

📊 Changes

6 files changed (+59 additions, -14 deletions)

View changed files

📝 docs/development/user-preferences.md (+1 -0)
📝 netbox/dcim/views.py (+6 -0)
📝 netbox/project-static/js/rack_elevations.js (+35 -9)
📝 netbox/templates/dcim/rack.html (+3 -2)
📝 netbox/templates/dcim/rack_elevation_list.html (+3 -2)
📝 netbox/users/api/views.py (+11 -1)

📄 Description

Fixes: 5203

  • Changed rack_elevation.js to show/hide images in case of preference is set and to send preference to server when user toggle it
  • Added post method to RackElevationListView (I can't find better place to add method that set new preference)
  • Made toggle-button glyph and attributes dependent on new property

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5434 **Author:** [@ogorov](https://github.com/ogorov) **Created:** 12/9/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (8) - [`a4c25e8`](https://github.com/netbox-community/netbox/commit/a4c25e8773d35f2549b6fe2cf0a536d2c40b9441) Added rack_elevation.show_images to user.preferences - [`a0e62c6`](https://github.com/netbox-community/netbox/commit/a0e62c6c871f52fd353d60b6c071cd8d5ab5561c) Merge branch 'develop' into develop-2.10 - [`8280b66`](https://github.com/netbox-community/netbox/commit/8280b66a7cb62e2cf696b7f196a47aff771ee09e) Fixes with new API endpoint - [`8de4cbb`](https://github.com/netbox-community/netbox/commit/8de4cbbf50f08997b4b6a9f931f07a252673a982) Merge remote-tracking branch 'True-NetBox/develop' into develop-2.10 - [`437fae4`](https://github.com/netbox-community/netbox/commit/437fae465df07bf09977bc1cba7810a8f8f62067) Add exception type for try catch of api method - [`5ca574d`](https://github.com/netbox-community/netbox/commit/5ca574d3467935dead88881776f7121de3dd2570) Fix exceptions in API - [`58c06aa`](https://github.com/netbox-community/netbox/commit/58c06aad5a36f4df97515bb52897ec092174d57a) Fixes for anonimous user - [`c326483`](https://github.com/netbox-community/netbox/commit/c3264835dc290c8cbdba9fb2460c65f90ea72ec5) Fix ### 📊 Changes **6 files changed** (+59 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `docs/development/user-preferences.md` (+1 -0) 📝 `netbox/dcim/views.py` (+6 -0) 📝 `netbox/project-static/js/rack_elevations.js` (+35 -9) 📝 `netbox/templates/dcim/rack.html` (+3 -2) 📝 `netbox/templates/dcim/rack_elevation_list.html` (+3 -2) 📝 `netbox/users/api/views.py` (+11 -1) </details> ### 📄 Description ### Fixes: [5203](https://github.com/netbox-community/netbox/issues/5203) - Changed rack_elevation.js to show/hide images in case of preference is set and to send preference to server when user toggle it - Added post method to RackElevationListView (I can't find better place to add method that set new preference) - Made toggle-button glyph and attributes dependent on new property --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:57 +01:00
adam closed this issue 2025-12-29 22:24:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?