starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5372] [MERGED] Closes #5274: Enable REST API support for custom fields #13012

New Issue
Closed
opened 2025-12-29 22:24:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5372
Author: @jeremystretch
Created: 11/23/2020
Status: ✅ Merged
Merged: 11/23/2020
Merged by: @jeremystretch

Base: develop-2.10 ← Head: 5274-custom-fields-api

📝 Commits (3)

  • 6fb080f Rename CustomFieldFilterSet
  • a05fe69 Add REST API endpoint for custom fields
  • 98f2d25 Add REST API test for custom fields

📊 Changes

13 files changed (+134 additions, -38 deletions)

View changed files

📝 netbox/circuits/filters.py (+3 -3)
📝 netbox/dcim/filters.py (+6 -6)
📝 netbox/extras/api/nested_serializers.py (+9 -0)
📝 netbox/extras/api/serializers.py (+22 -1)
📝 netbox/extras/api/urls.py (+3 -0)
📝 netbox/extras/api/views.py (+17 -9)
📝 netbox/extras/filters.py (+9 -2)
📝 netbox/extras/models/customfields.py (+3 -2)
📝 netbox/extras/tests/test_api.py (+48 -1)
📝 netbox/ipam/filters.py (+7 -7)
📝 netbox/secrets/filters.py (+2 -2)
📝 netbox/tenancy/filters.py (+2 -2)
📝 netbox/virtualization/filters.py (+3 -3)

📄 Description

Closes: #5274

Adds a REST API endpoint for CustomField instances with associated tests. This is necessary to replace the functionality afforded by the old _custom_field_choices API endpoint.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5372 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/23/2020 **Status:** ✅ Merged **Merged:** 11/23/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.10` ← **Head:** `5274-custom-fields-api` --- ### 📝 Commits (3) - [`6fb080f`](https://github.com/netbox-community/netbox/commit/6fb080ff4c66118b0b1399fb12c8c1743431f738) Rename CustomFieldFilterSet - [`a05fe69`](https://github.com/netbox-community/netbox/commit/a05fe690436ff465135090354d6c346fe38a056c) Add REST API endpoint for custom fields - [`98f2d25`](https://github.com/netbox-community/netbox/commit/98f2d2501b54217a329741bbb2afe5aad86a4b39) Add REST API test for custom fields ### 📊 Changes **13 files changed** (+134 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/filters.py` (+3 -3) 📝 `netbox/dcim/filters.py` (+6 -6) 📝 `netbox/extras/api/nested_serializers.py` (+9 -0) 📝 `netbox/extras/api/serializers.py` (+22 -1) 📝 `netbox/extras/api/urls.py` (+3 -0) 📝 `netbox/extras/api/views.py` (+17 -9) 📝 `netbox/extras/filters.py` (+9 -2) 📝 `netbox/extras/models/customfields.py` (+3 -2) 📝 `netbox/extras/tests/test_api.py` (+48 -1) 📝 `netbox/ipam/filters.py` (+7 -7) 📝 `netbox/secrets/filters.py` (+2 -2) 📝 `netbox/tenancy/filters.py` (+2 -2) 📝 `netbox/virtualization/filters.py` (+3 -3) </details> ### 📄 Description ### Closes: #5274 Adds a REST API endpoint for CustomField instances with associated tests. This is necessary to replace the functionality afforded by the old `_custom_field_choices` API endpoint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:53 +01:00
adam closed this issue 2025-12-29 22:24:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13012
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?