starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5268] [CLOSED] update: autocomplete attr on login fields #12993

New Issue
Closed
opened 2025-12-29 22:24:47 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5268
Author: @ndom91
Created: 10/26/2020
Status: ❌ Closed

Base: develop ← Head: fix-login-autocomplete

📝 Commits (2)

  • 080efd9 update: autocomplete attr on login fields
  • 64f8c64 update: password autocomplete value MDN

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 netbox/users/forms.py (+2 -0)

📄 Description

Updated the login field autocomplete values in accordance with modern security best practices.

According to MDN browsers ignore autocomplete='off' on password fields, but autocomplete='new-password' should do the trick.

Source: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5268 **Author:** [@ndom91](https://github.com/ndom91) **Created:** 10/26/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix-login-autocomplete` --- ### 📝 Commits (2) - [`080efd9`](https://github.com/netbox-community/netbox/commit/080efd9a24dda1f88c4c0be55a37d6290d6139a9) update: autocomplete attr on login fields - [`64f8c64`](https://github.com/netbox-community/netbox/commit/64f8c6432e6d81ef56188e2cc2b4358c7585fdfe) update: password autocomplete value MDN ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/users/forms.py` (+2 -0) </details> ### 📄 Description Updated the login field autocomplete values in accordance with modern security best practices. According to MDN browsers ignore `autocomplete='off'` on password fields, but `autocomplete='new-password'` should do the trick. Source: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:47 +01:00
adam closed this issue 2025-12-29 22:24:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?