starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5068] [CLOSED] Fix #5050 by making virtualization.0016_replicate_interfaces depend on dcim.0082_3569_interface_fields #12962

New Issue
Closed
opened 2025-12-29 22:24:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5068
Author: @nward
Created: 8/28/2020
Status: ❌ Closed

Base: develop ← Head: fix_5050_virtualiztion_replicate_interfaces_null_value

📝 Commits (1)

  • 7d26558 Make 0016_replicate_interfaces depend on dcim.0082_3569_interface_fields

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 netbox/virtualization/migrations/0016_replicate_interfaces.py (+1 -0)

📄 Description

Fixes: #5050

Add a migration dependency so virtualization.0016_replicate_interfaces depends on dcim.0082_3569_interface_fields.

0016_replicate_interfaces copies mode from dcim_interface to virtualization_vminterface. If 0016_replicate_interfaces runs before dcim.0082_3569_interface_fields, it will fail, as prior to dcim.0082_3569_interface_fields the mode field is an integer which permits null, while 0016_replicate_interfaces is expecting this to be a varchar which defaults to empty string - virtualization_vminterface does not permit null so trying to copy null values fails.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5068 **Author:** [@nward](https://github.com/nward) **Created:** 8/28/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix_5050_virtualiztion_replicate_interfaces_null_value` --- ### 📝 Commits (1) - [`7d26558`](https://github.com/netbox-community/netbox/commit/7d26558551a584e16dd8e2d0c31903beed20d7c5) Make 0016_replicate_interfaces depend on dcim.0082_3569_interface_fields ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/virtualization/migrations/0016_replicate_interfaces.py` (+1 -0) </details> ### 📄 Description ### Fixes: #5050 Add a migration dependency so virtualization.0016_replicate_interfaces depends on dcim.0082_3569_interface_fields. 0016_replicate_interfaces copies mode from dcim_interface to virtualization_vminterface. If 0016_replicate_interfaces runs before dcim.0082_3569_interface_fields, it will fail, as prior to dcim.0082_3569_interface_fields the mode field is an integer which permits null, while 0016_replicate_interfaces is expecting this to be a varchar which defaults to empty string - virtualization_vminterface does not permit null so trying to copy null values fails. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:37 +01:00
adam closed this issue 2025-12-29 22:24:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?