[PR #4852] [MERGED] Some additional fixes to scripts/reports background running (2.9) #12932

New Issue

adam · 2025-12-29T22:24:26+01:00

adam commented

2025-12-29 22:24:26 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4852
Author: @glennmatthews
Created: 7/14/2020
Status: ✅ Merged
Merged: 7/20/2020
Merged by: @jeremystretch

Base: develop-2.9 ← Head: gfm-2006-continued

📝 Commits (2)

49c6bee Fix jobresult success label spelling
d8b0a11 Save JobResult even for a script run with commit=False

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 netbox/extras/choices.py (+1 -1)
📝 netbox/extras/scripts.py (+4 -2)

📄 Description

Fixes: #2006

Follow-up to #4799. Fixes two issues:

success log result was misspelled as sucess, which was causing display issues in the result detail view (since label-sucess (sic) is not a defined Bootstrap style).
If a script was run with commit=False, its JobResult status would remain as running indefinitely even after the script execution had actually completed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4852 **Author:** [@glennmatthews](https://github.com/glennmatthews) **Created:** 7/14/2020 **Status:** ✅ Merged **Merged:** 7/20/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.9` ← **Head:** `gfm-2006-continued` --- ### 📝 Commits (2) - [`49c6bee`](https://github.com/netbox-community/netbox/commit/49c6bee6d7ad87182fc9a5cfaafd38a29f334179) Fix jobresult success label spelling - [`d8b0a11`](https://github.com/netbox-community/netbox/commit/d8b0a11a496e405c0e1e198477b65e6f630f0222) Save JobResult even for a script run with commit=False ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/choices.py` (+1 -1) 📝 `netbox/extras/scripts.py` (+4 -2) </details> ### 📄 Description ### Fixes: #2006 Follow-up to #4799. Fixes two issues: 1) `success` log result was misspelled as `sucess`, which was causing display issues in the result detail view (since `label-sucess` (sic) is not a defined Bootstrap style). 2) If a script was run with `commit=False`, its JobResult status would remain as `running` indefinitely even after the script execution had actually completed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:24:26 +01:00

adam closed this issue

2025-12-29 22:24:26 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12932