[PR #4858] [MERGED] Closes #4857: Drop support for legacy numeric choice field values #12931

New Issue

adam · 2025-12-29T22:24:26+01:00

adam commented

2025-12-29 22:24:26 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4858
Author: @jeremystretch
Created: 7/15/2020
Status: ✅ Merged
Merged: 7/15/2020
Merged by: @jeremystretch

Base: develop-2.9 ← Head: 4857-remove-legacy-choice-ids

📝 Commits (1)

19d0d6f Closes #4857: Drop support for legacy numeric choice field values

📊 Changes

9 files changed (+4 additions, -337 deletions)

View changed files

📝 docs/release-notes/version-2.9.md (+1 -0)
📝 netbox/circuits/choices.py (+0 -9)
📝 netbox/dcim/choices.py (+0 -205)
📝 netbox/extras/choices.py (+0 -34)
📝 netbox/ipam/choices.py (+0 -36)
📝 netbox/utilities/api.py (+2 -13)
📝 netbox/utilities/choices.py (+0 -20)
📝 netbox/utilities/tests/test_choices.py (+1 -14)
📝 netbox/virtualization/choices.py (+0 -6)

📄 Description

Fixes: #4857

Remove all LEGACY_MAP definitions on ChoiceSets
Drop the id field from API representations of choice fields
No longer accept a numeric ID in place of its corresponding string value

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4858 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/15/2020 **Status:** ✅ Merged **Merged:** 7/15/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.9` ← **Head:** `4857-remove-legacy-choice-ids` --- ### 📝 Commits (1) - [`19d0d6f`](https://github.com/netbox-community/netbox/commit/19d0d6ff10e9372d8f81e1e079f15d48e19f6150) Closes #4857: Drop support for legacy numeric choice field values ### 📊 Changes **9 files changed** (+4 additions, -337 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.9.md` (+1 -0) 📝 `netbox/circuits/choices.py` (+0 -9) 📝 `netbox/dcim/choices.py` (+0 -205) 📝 `netbox/extras/choices.py` (+0 -34) 📝 `netbox/ipam/choices.py` (+0 -36) 📝 `netbox/utilities/api.py` (+2 -13) 📝 `netbox/utilities/choices.py` (+0 -20) 📝 `netbox/utilities/tests/test_choices.py` (+1 -14) 📝 `netbox/virtualization/choices.py` (+0 -6) </details> ### 📄 Description ### Fixes: #4857 - Remove all `LEGACY_MAP` definitions on ChoiceSets - Drop the `id` field from API representations of choice fields - No longer accept a numeric ID in place of its corresponding string value --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:24:26 +01:00

adam closed this issue

2025-12-29 22:24:26 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12931