starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4847] [CLOSED] CircuitTermination cleanup (Fixes #4812) #12930

New Issue
Closed
opened 2025-12-29 22:24:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4847
Author: @steffann
Created: 7/13/2020
Status: ❌ Closed

Base: develop ← Head: 4812-circuittermination-cleanup

📝 Commits (6)

  • bf1c0b7 Remove unused part of template (#4812 example 1)
  • 15c3934 Handle case where trace ends at cable termination (#4812 example 2)
  • 3908b90 Handle case where trace is no longer connected (#4812 example 3)
  • f3c0a88 Add a management command to rebuild all the connected endpoints
  • c2a63b9 Revert "Add a management command to rebuild all the connected endpoints"
  • 36ca1b8 Implement re-tracing all paths in a migration

📊 Changes

3 files changed (+344 additions, -28 deletions)

View changed files

➕ netbox/dcim/migrations/0115_retrace.py (+320 -0)
📝 netbox/dcim/signals.py (+14 -1)
📝 netbox/templates/dcim/inc/interface.html (+10 -27)

📄 Description

Fixes: #4812

I made the following choices:

  • When an interface has a connected endpoint show it. Do not show "via …" anymore. The part of the template that handled that (no longer existing) situation has been removed. (see #4812 example 1)
  • When a trace ends at the far end of a circuit store the near circuit termination. This was the "old" behaviour before the follow_circuits parameter to trace() was removed. This was useful to show the circuit and remote site in the user interface, so that has been restored. (see #4812 example 2)
  • When a trace no longer leads anywhere make sure the connected endpoint is cleared (see #4812 example 3)

Each of these has been separately committed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4847 **Author:** [@steffann](https://github.com/steffann) **Created:** 7/13/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `4812-circuittermination-cleanup` --- ### 📝 Commits (6) - [`bf1c0b7`](https://github.com/netbox-community/netbox/commit/bf1c0b7b1c92ffc9ac9d54f074a18feddad6bfb7) Remove unused part of template (#4812 example 1) - [`15c3934`](https://github.com/netbox-community/netbox/commit/15c39340c4d33e66819688c876c364184803d598) Handle case where trace ends at cable termination (#4812 example 2) - [`3908b90`](https://github.com/netbox-community/netbox/commit/3908b905e5795a9f3e5a06bcf5aca55088436d95) Handle case where trace is no longer connected (#4812 example 3) - [`f3c0a88`](https://github.com/netbox-community/netbox/commit/f3c0a88e66cddba647dea08b6da0412824a464a7) Add a management command to rebuild all the connected endpoints - [`c2a63b9`](https://github.com/netbox-community/netbox/commit/c2a63b9960a3daa0b78a5a5d3d677b28063c111b) Revert "Add a management command to rebuild all the connected endpoints" - [`36ca1b8`](https://github.com/netbox-community/netbox/commit/36ca1b8135a58c266e88a231920e07b7ada5ce21) Implement re-tracing all paths in a migration ### 📊 Changes **3 files changed** (+344 additions, -28 deletions) <details> <summary>View changed files</summary> ➕ `netbox/dcim/migrations/0115_retrace.py` (+320 -0) 📝 `netbox/dcim/signals.py` (+14 -1) 📝 `netbox/templates/dcim/inc/interface.html` (+10 -27) </details> ### 📄 Description ### Fixes: #4812 I made the following choices: - When an interface has a connected endpoint show it. Do not show "via …" anymore. The part of the template that handled that (no longer existing) situation has been removed. (see #4812 example 1) - When a trace ends at the far end of a circuit store the near circuit termination. This was the "old" behaviour before the `follow_circuits` parameter to `trace()` was removed. This was useful to show the circuit and remote site in the user interface, so that has been restored. (see #4812 example 2) - When a trace no longer leads anywhere make sure the connected endpoint is cleared (see #4812 example 3) Each of these has been separately committed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:25 +01:00
adam closed this issue 2025-12-29 22:24:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12930
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?