starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4787] [MERGED] #2018: Add name field to VirtualChassis model #12920

New Issue
Closed
opened 2025-12-29 22:24:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4787
Author: @jeremystretch
Created: 6/24/2020
Status: ✅ Merged
Merged: 6/24/2020
Merged by: @jeremystretch

Base: develop-2.9 ← Head: 2018-virtual-chassis-name

📝 Commits (3)

  • 59c1e34 Initial work on #2018: Add name to VirtualChassis
  • 36cf40f Enable CSV import for virtual chassis
  • e2398c8 Fix signal logic

📊 Changes

15 files changed (+243 additions, -116 deletions)

View changed files

📝 netbox/dcim/api/nested_serializers.py (+1 -1)
📝 netbox/dcim/api/serializers.py (+2 -2)
📝 netbox/dcim/forms.py (+81 -2)
➕ netbox/dcim/migrations/0110_virtualchassis_name.py (+46 -0)
📝 netbox/dcim/models/__init__.py (+18 -13)
📝 netbox/dcim/signals.py (+6 -7)
📝 netbox/dcim/tables.py (+5 -3)
📝 netbox/dcim/tests/test_api.py (+9 -8)
📝 netbox/dcim/tests/test_views.py (+20 -17)
📝 netbox/dcim/urls.py (+1 -0)
📝 netbox/dcim/views.py (+12 -56)
📝 netbox/templates/dcim/device_list.html (+0 -5)
📝 netbox/templates/dcim/virtualchassis.html (+14 -2)
➕ netbox/templates/dcim/virtualchassis_add.html (+22 -0)
📝 netbox/templates/inc/nav_menu.html (+6 -0)

📄 Description

Fixes: #2018

  • Adds a mandatory name field to the VirtualChassis model
  • Copy names from existing master devices during migration (VCs with unnamed masters will be named by PK)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4787 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/24/2020 **Status:** ✅ Merged **Merged:** 6/24/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.9` ← **Head:** `2018-virtual-chassis-name` --- ### 📝 Commits (3) - [`59c1e34`](https://github.com/netbox-community/netbox/commit/59c1e34024dba3f33a8a85e772611eacd22f79f0) Initial work on #2018: Add name to VirtualChassis - [`36cf40f`](https://github.com/netbox-community/netbox/commit/36cf40f25cf8ad6b231cba3a2b8d387cced0abd6) Enable CSV import for virtual chassis - [`e2398c8`](https://github.com/netbox-community/netbox/commit/e2398c8c0e2932d6d0adad9dd4c6033c66d394d5) Fix signal logic ### 📊 Changes **15 files changed** (+243 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/nested_serializers.py` (+1 -1) 📝 `netbox/dcim/api/serializers.py` (+2 -2) 📝 `netbox/dcim/forms.py` (+81 -2) ➕ `netbox/dcim/migrations/0110_virtualchassis_name.py` (+46 -0) 📝 `netbox/dcim/models/__init__.py` (+18 -13) 📝 `netbox/dcim/signals.py` (+6 -7) 📝 `netbox/dcim/tables.py` (+5 -3) 📝 `netbox/dcim/tests/test_api.py` (+9 -8) 📝 `netbox/dcim/tests/test_views.py` (+20 -17) 📝 `netbox/dcim/urls.py` (+1 -0) 📝 `netbox/dcim/views.py` (+12 -56) 📝 `netbox/templates/dcim/device_list.html` (+0 -5) 📝 `netbox/templates/dcim/virtualchassis.html` (+14 -2) ➕ `netbox/templates/dcim/virtualchassis_add.html` (+22 -0) 📝 `netbox/templates/inc/nav_menu.html` (+6 -0) </details> ### 📄 Description ### Fixes: #2018 - Adds a mandatory `name` field to the VirtualChassis model - Copy names from existing master devices during migration (VCs with unnamed masters will be named by PK) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:22 +01:00
adam closed this issue 2025-12-29 22:24:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12920
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?