starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4770] [MERGED] Closes #3703: Restrict tag creation #12918

New Issue
Closed
opened 2025-12-29 22:24:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4770
Author: @jeremystretch
Created: 6/17/2020
Status: ✅ Merged
Merged: 6/17/2020
Merged by: @jeremystretch

Base: develop-2.9 ← Head: 3703-limit-tag-creation

📝 Commits (10+)

  • da906f4 Standardize add, import, and export functionality for tags
  • 7dc4f8d Remove TagField
  • e905a36 Update tests for tag changes
  • 448dc14 Replace TaggitSerializer and TagListSerializerField with TaggedObjectSerializer
  • d0f0aef Remove django-taggit-serializer
  • ef978b2 Update TaggedItemTest
  • bb755da Update tests
  • d1adc5e Update release notes for #3703
  • 5e71bad Fix serialization of tags upon object deletion
  • 54ece34 DummyQuerySet should be iterable to allow for serialization

📊 Changes

37 files changed (+349 additions, -250 deletions)

View changed files

📝 base_requirements.txt (+0 -4)
📝 docs/release-notes/version-2.9.md (+15 -0)
📝 netbox/circuits/api/serializers.py (+3 -5)
📝 netbox/circuits/forms.py (+5 -3)
📝 netbox/circuits/tests/test_views.py (+2 -3)
📝 netbox/dcim/api/serializers.py (+19 -41)
📝 netbox/dcim/forms.py (+54 -26)
📝 netbox/dcim/tests/test_views.py (+44 -26)
📝 netbox/extras/api/nested_serializers.py (+1 -2)
📝 netbox/extras/api/serializers.py (+22 -0)
📝 netbox/extras/forms.py (+20 -12)
📝 netbox/extras/models/tags.py (+10 -0)
📝 netbox/extras/tests/test_api.py (+1 -1)
📝 netbox/extras/tests/test_changelog.py (+0 -11)
📝 netbox/extras/tests/test_tags.py (+25 -14)
📝 netbox/extras/tests/test_views.py (+8 -10)
📝 netbox/extras/urls.py (+2 -0)
📝 netbox/extras/views.py (+19 -14)
📝 netbox/ipam/api/serializers.py (+7 -13)
📝 netbox/ipam/forms.py (+17 -7)

...and 17 more files

📄 Description

Fixes: #3703

  • Disable automatic tag creation
  • Remove django-taggit-serializer

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4770 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/17/2020 **Status:** ✅ Merged **Merged:** 6/17/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.9` ← **Head:** `3703-limit-tag-creation` --- ### 📝 Commits (10+) - [`da906f4`](https://github.com/netbox-community/netbox/commit/da906f48d90161af90703e1cd49bad9f769b8bf7) Standardize add, import, and export functionality for tags - [`7dc4f8d`](https://github.com/netbox-community/netbox/commit/7dc4f8d5ccf0b941c0fae0b5c16e486f16ae4038) Remove TagField - [`e905a36`](https://github.com/netbox-community/netbox/commit/e905a36fb2be1a2d4867d96fc7c44b83002d2fba) Update tests for tag changes - [`448dc14`](https://github.com/netbox-community/netbox/commit/448dc1442cf002480f4bb3cac19b9aee790e0e41) Replace TaggitSerializer and TagListSerializerField with TaggedObjectSerializer - [`d0f0aef`](https://github.com/netbox-community/netbox/commit/d0f0aef2efdeeb54bd8b1104c6a5c708efca99d7) Remove django-taggit-serializer - [`ef978b2`](https://github.com/netbox-community/netbox/commit/ef978b2ebfbb6131a83b7f6326f45acbf7ac3085) Update TaggedItemTest - [`bb755da`](https://github.com/netbox-community/netbox/commit/bb755daf8b8cdb7f326107b73c465364efccb556) Update tests - [`d1adc5e`](https://github.com/netbox-community/netbox/commit/d1adc5ea9b36db46d425ef9dae357291bcf9a256) Update release notes for #3703 - [`5e71bad`](https://github.com/netbox-community/netbox/commit/5e71bad5cf68dbaa737b8a4f5b85bbce0c80987a) Fix serialization of tags upon object deletion - [`54ece34`](https://github.com/netbox-community/netbox/commit/54ece346bc1ad58589a734517778cb954ed653b6) DummyQuerySet should be iterable to allow for serialization ### 📊 Changes **37 files changed** (+349 additions, -250 deletions) <details> <summary>View changed files</summary> 📝 `base_requirements.txt` (+0 -4) 📝 `docs/release-notes/version-2.9.md` (+15 -0) 📝 `netbox/circuits/api/serializers.py` (+3 -5) 📝 `netbox/circuits/forms.py` (+5 -3) 📝 `netbox/circuits/tests/test_views.py` (+2 -3) 📝 `netbox/dcim/api/serializers.py` (+19 -41) 📝 `netbox/dcim/forms.py` (+54 -26) 📝 `netbox/dcim/tests/test_views.py` (+44 -26) 📝 `netbox/extras/api/nested_serializers.py` (+1 -2) 📝 `netbox/extras/api/serializers.py` (+22 -0) 📝 `netbox/extras/forms.py` (+20 -12) 📝 `netbox/extras/models/tags.py` (+10 -0) 📝 `netbox/extras/tests/test_api.py` (+1 -1) 📝 `netbox/extras/tests/test_changelog.py` (+0 -11) 📝 `netbox/extras/tests/test_tags.py` (+25 -14) 📝 `netbox/extras/tests/test_views.py` (+8 -10) 📝 `netbox/extras/urls.py` (+2 -0) 📝 `netbox/extras/views.py` (+19 -14) 📝 `netbox/ipam/api/serializers.py` (+7 -13) 📝 `netbox/ipam/forms.py` (+17 -7) _...and 17 more files_ </details> ### 📄 Description ### Fixes: #3703 - Disable automatic tag creation - Remove django-taggit-serializer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:22 +01:00
adam closed this issue 2025-12-29 22:24:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12918
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?