starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4781] [MERGED] #4721: Move VM interfaces to a separate model (WIP) #12917

New Issue
Closed
opened 2025-12-29 22:24:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4781
Author: @jeremystretch
Created: 6/22/2020
Status: ✅ Merged
Merged: 6/24/2020
Merged by: @jeremystretch

Base: develop-2.9 ← Head: 4721-virtualmachine-interface

📝 Commits (10+)

  • 181bcd7 Fix schema migrations for device components
  • 6cb31a2 Initial work on #4721 (WIP)
  • e76b1f1 Fix assigned_object field
  • 2608b3f Separate VM interface view and template
  • 31bb70d Fixed IPAM tests
  • f2b2628 Disable VM interface bulk creation testing
  • 380a5cf Fix IP choices for DeviceForm
  • 37564d6 Misc test fixes
  • 7b24984 Update IPAddressSerializer
  • 490dee1 Merge branch 'develop-2.9' into 4721-virtualmachine-interface

📊 Changes

49 files changed (+1235 additions, -651 deletions)

View changed files

📝 netbox/dcim/forms.py (+7 -35)
➕ netbox/dcim/migrations/0109_interface_remove_vm.py (+18 -0)
📝 netbox/dcim/models/__init__.py (+3 -2)
📝 netbox/dcim/models/device_components.py (+47 -80)
📝 netbox/dcim/tables.py (+5 -20)
📝 netbox/dcim/tests/test_filters.py (+2 -2)
📝 netbox/dcim/views.py (+3 -55)
📝 netbox/ipam/api/serializers.py (+21 -4)
📝 netbox/ipam/api/views.py (+1 -2)
📝 netbox/ipam/constants.py (+7 -0)
📝 netbox/ipam/filters.py (+42 -19)
📝 netbox/ipam/forms.py (+77 -54)
➕ netbox/ipam/migrations/0037_ipaddress_assignment.py (+40 -0)
📝 netbox/ipam/models.py (+43 -49)
📝 netbox/ipam/tables.py (+8 -24)
📝 netbox/ipam/tests/test_filters.py (+31 -20)
📝 netbox/ipam/tests/test_views.py (+0 -1)
📝 netbox/ipam/views.py (+17 -16)
📝 netbox/templates/dcim/inc/interface.html (+2 -2)
📝 netbox/templates/dcim/interface.html (+10 -14)

...and 29 more files

📄 Description

Closes: #4721

  • Introduce the virtualization.Interface model
  • Replicate existing VM interfaces to the new model and delete all original instances
  • Update REST API serializers accordingly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4781 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/22/2020 **Status:** ✅ Merged **Merged:** 6/24/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.9` ← **Head:** `4721-virtualmachine-interface` --- ### 📝 Commits (10+) - [`181bcd7`](https://github.com/netbox-community/netbox/commit/181bcd70ad7fd40e28a35a792bcf76a795430adb) Fix schema migrations for device components - [`6cb31a2`](https://github.com/netbox-community/netbox/commit/6cb31a274fdcdf8b93ea5f46cbfa480b4ae70801) Initial work on #4721 (WIP) - [`e76b1f1`](https://github.com/netbox-community/netbox/commit/e76b1f1daae8919d4e4ad1872100c8fd478acc86) Fix assigned_object field - [`2608b3f`](https://github.com/netbox-community/netbox/commit/2608b3f9f391ca85a9cd9a78b3624d529a7e4e30) Separate VM interface view and template - [`31bb70d`](https://github.com/netbox-community/netbox/commit/31bb70d9a251cfb39cbb77f03907bfd1be12a554) Fixed IPAM tests - [`f2b2628`](https://github.com/netbox-community/netbox/commit/f2b26282b873a7c09b404bc4a74aeea49309e035) Disable VM interface bulk creation testing - [`380a5cf`](https://github.com/netbox-community/netbox/commit/380a5cf8a7d805f2d8b2f4ae4baa63517aaa27cc) Fix IP choices for DeviceForm - [`37564d6`](https://github.com/netbox-community/netbox/commit/37564d630a19af78b88c6dda92d72e620ed40eef) Misc test fixes - [`7b24984`](https://github.com/netbox-community/netbox/commit/7b24984280171df30d2b3fd438103f83653dcd8d) Update IPAddressSerializer - [`490dee1`](https://github.com/netbox-community/netbox/commit/490dee1fa05cdb0d573f7aafcba1eead4fd27a8a) Merge branch 'develop-2.9' into 4721-virtualmachine-interface ### 📊 Changes **49 files changed** (+1235 additions, -651 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+7 -35) ➕ `netbox/dcim/migrations/0109_interface_remove_vm.py` (+18 -0) 📝 `netbox/dcim/models/__init__.py` (+3 -2) 📝 `netbox/dcim/models/device_components.py` (+47 -80) 📝 `netbox/dcim/tables.py` (+5 -20) 📝 `netbox/dcim/tests/test_filters.py` (+2 -2) 📝 `netbox/dcim/views.py` (+3 -55) 📝 `netbox/ipam/api/serializers.py` (+21 -4) 📝 `netbox/ipam/api/views.py` (+1 -2) 📝 `netbox/ipam/constants.py` (+7 -0) 📝 `netbox/ipam/filters.py` (+42 -19) 📝 `netbox/ipam/forms.py` (+77 -54) ➕ `netbox/ipam/migrations/0037_ipaddress_assignment.py` (+40 -0) 📝 `netbox/ipam/models.py` (+43 -49) 📝 `netbox/ipam/tables.py` (+8 -24) 📝 `netbox/ipam/tests/test_filters.py` (+31 -20) 📝 `netbox/ipam/tests/test_views.py` (+0 -1) 📝 `netbox/ipam/views.py` (+17 -16) 📝 `netbox/templates/dcim/inc/interface.html` (+2 -2) 📝 `netbox/templates/dcim/interface.html` (+10 -14) _...and 29 more files_ </details> ### 📄 Description ### Closes: #4721 - Introduce the `virtualization.Interface` model - Replicate existing VM interfaces to the new model and delete all original instances - Update REST API serializers accordingly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:22 +01:00
adam closed this issue 2025-12-29 22:24:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12917
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?