[PR #4723] [MERGED] Closes: #4615 Physical labels #12908

Closed
opened 2025-12-29 22:24:18 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4723
Author: @jsenecal
Created: 6/4/2020
Status: Merged
Merged: 6/11/2020
Merged by: @jeremystretch

Base: develop-2.9Head: 4615_interface_label


📝 Commits (10+)

  • cde1db4 Add label to interface models
  • e9f8640 Add label to Interface serializers
  • f885112 Add the label to the string representation
  • a06d744 Add label to *ports models
  • 1fae9af Add label to *port serializers
  • e21cbf2 Add the label to the string representation
  • d65cead Return an empty list if value is None
  • 286a3e6 Add label to forms, views and templates
  • 892c0e3 Leftover fix
  • 90bc1cd Test forms and views with labels

📊 Changes

11 files changed (+275 additions, -109 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+12 -12)
📝 netbox/dcim/forms.py (+27 -60)
netbox/dcim/migrations/0107_component_labels.py (+73 -0)
📝 netbox/dcim/models/device_component_templates.py (+35 -18)
📝 netbox/dcim/models/device_components.py (+37 -15)
📝 netbox/dcim/tests/test_forms.py (+42 -0)
📝 netbox/dcim/tests/test_views.py (+4 -0)
📝 netbox/templates/dcim/interface.html (+4 -0)
📝 netbox/templates/dcim/interface_edit.html (+1 -0)
📝 netbox/utilities/forms.py (+27 -0)
📝 netbox/utilities/views.py (+13 -4)

📄 Description

Fixes: #4615

Adds the ability to document the Physical label on an interface, power port, etc


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4723 **Author:** [@jsenecal](https://github.com/jsenecal) **Created:** 6/4/2020 **Status:** ✅ Merged **Merged:** 6/11/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.9` ← **Head:** `4615_interface_label` --- ### 📝 Commits (10+) - [`cde1db4`](https://github.com/netbox-community/netbox/commit/cde1db443673036d407a6ff9ea68eb585d0924b7) Add `label` to interface models - [`e9f8640`](https://github.com/netbox-community/netbox/commit/e9f8640ee680e6eacf49a1ad0523bde1055dd86c) Add `label` to Interface serializers - [`f885112`](https://github.com/netbox-community/netbox/commit/f8851121abd26eaa2a761c04375d95f76b666acb) Add the `label` to the string representation - [`a06d744`](https://github.com/netbox-community/netbox/commit/a06d74472da1c4ffbcb8e3fc23b9b8f62af079f0) Add `label` to *ports models - [`1fae9af`](https://github.com/netbox-community/netbox/commit/1fae9aff0c90d5217309263388ed02925435d4f2) Add `label` to *port serializers - [`e21cbf2`](https://github.com/netbox-community/netbox/commit/e21cbf2a0667e2d014740a1bfef06a056c238a40) Add the `label` to the string representation - [`d65cead`](https://github.com/netbox-community/netbox/commit/d65cead212dc781a6dbbe35ea15eea7b75023da9) Return an empty list if value is None - [`286a3e6`](https://github.com/netbox-community/netbox/commit/286a3e6ca296609201d3f02892a3d50c338b9f78) Add `label` to forms, views and templates - [`892c0e3`](https://github.com/netbox-community/netbox/commit/892c0e3d8be75e7d7e31c97b7bd01bdd5f8e5c0f) Leftover fix - [`90bc1cd`](https://github.com/netbox-community/netbox/commit/90bc1cd95162a2193ef1a470a85cd7b74a4e0634) Test forms and views with labels ### 📊 Changes **11 files changed** (+275 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+12 -12) 📝 `netbox/dcim/forms.py` (+27 -60) ➕ `netbox/dcim/migrations/0107_component_labels.py` (+73 -0) 📝 `netbox/dcim/models/device_component_templates.py` (+35 -18) 📝 `netbox/dcim/models/device_components.py` (+37 -15) 📝 `netbox/dcim/tests/test_forms.py` (+42 -0) 📝 `netbox/dcim/tests/test_views.py` (+4 -0) 📝 `netbox/templates/dcim/interface.html` (+4 -0) 📝 `netbox/templates/dcim/interface_edit.html` (+1 -0) 📝 `netbox/utilities/forms.py` (+27 -0) 📝 `netbox/utilities/views.py` (+13 -4) </details> ### 📄 Description ### Fixes: #4615 Adds the ability to document the Physical label on an interface, power port, etc --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:18 +01:00
adam closed this issue 2025-12-29 22:24:19 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12908