starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4592] [MERGED] 4591: make single front/rear port work when between panels #12883

New Issue
Closed
opened 2025-12-29 22:24:10 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4592
Author: @steffann
Created: 5/7/2020
Status: ✅ Merged
Merged: 5/8/2020
Merged by: @jeremystretch

Base: 4591-single-position-rearports ← Head: 4591-nested-single-port-panel

📝 Commits (4)

  • ab6c3b7 make single front/rear port work when between panels
  • 2e95e04 Integrate patch panel building into one list
  • 79b2b20 Recreate the model instance instead of re-saving a deleted model
  • 7a48a24 Restore original test_connection_via_single_rear_port test and make separate test for one-on-one panels

📊 Changes

2 files changed (+232 additions, -16 deletions)

View changed files

📝 netbox/dcim/models/device_components.py (+20 -14)
📝 netbox/dcim/tests/test_models.py (+212 -2)

📄 Description

Fixes: #4591

This patch considers 1:1 patch panels as cable extenders and will not push/pop the front port position (which is always 1) on the position_stack. That way 1:1 panels don't interfere with 1:n patch panels.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4592 **Author:** [@steffann](https://github.com/steffann) **Created:** 5/7/2020 **Status:** ✅ Merged **Merged:** 5/8/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `4591-single-position-rearports` ← **Head:** `4591-nested-single-port-panel` --- ### 📝 Commits (4) - [`ab6c3b7`](https://github.com/netbox-community/netbox/commit/ab6c3b7a74319a459f60a973623d9f29c82c2c9d) make single front/rear port work when between panels - [`2e95e04`](https://github.com/netbox-community/netbox/commit/2e95e044af55283610d61273de9dd040459fa8e4) Integrate patch panel building into one list - [`79b2b20`](https://github.com/netbox-community/netbox/commit/79b2b20046ca30d3b50cca1c48ee38978b591098) Recreate the model instance instead of re-saving a deleted model - [`7a48a24`](https://github.com/netbox-community/netbox/commit/7a48a24fee2015f43cc5d82e404685ee279ffec3) Restore original test_connection_via_single_rear_port test and make separate test for one-on-one panels ### 📊 Changes **2 files changed** (+232 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/device_components.py` (+20 -14) 📝 `netbox/dcim/tests/test_models.py` (+212 -2) </details> ### 📄 Description ### Fixes: #4591 This patch considers 1:1 patch panels as cable extenders and will not push/pop the front port position (which is always 1) on the `position_stack`. That way 1:1 panels don't interfere with 1:n patch panels. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:10 +01:00
adam closed this issue 2025-12-29 22:24:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12883
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?