starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4586] [MERGED] Fixes #4584 #12881

New Issue
Closed
opened 2025-12-29 22:24:10 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4586
Author: @jeremystretch
Created: 5/6/2020
Status: ✅ Merged
Merged: 5/6/2020
Merged by: @jeremystretch

Base: develop ← Head: 4584-id-filters

📝 Commits (2)

  • 4d5d298 Update super() call for get_filters()
  • 1ccb316 Ensure all model FilterSets support the 'id' field

📊 Changes

15 files changed (+163 additions, -97 deletions)

View changed files

📝 netbox/circuits/filters.py (+2 -2)
📝 netbox/circuits/tests/test_filters.py (+8 -0)
📝 netbox/dcim/filters.py (+4 -4)
📝 netbox/dcim/tests/test_filters.py (+45 -57)
📝 netbox/extras/filters.py (+6 -5)
📝 netbox/extras/tests/test_filters.py (+44 -1)
📝 netbox/ipam/filters.py (+6 -6)
📝 netbox/ipam/tests/test_filters.py (+27 -6)
📝 netbox/secrets/filters.py (+1 -1)
📝 netbox/secrets/tests/test_filters.py (+5 -2)
📝 netbox/tenancy/filters.py (+1 -1)
📝 netbox/tenancy/tests/test_filters.py (+5 -2)
📝 netbox/utilities/filters.py (+1 -3)
📝 netbox/virtualization/filters.py (+1 -1)
📝 netbox/virtualization/tests/test_filters.py (+7 -6)

📄 Description

Fixes: #4584

  • Updates all model-based FilterSets to support filtering by id
  • Extends filter tests as necessary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4586 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/6/2020 **Status:** ✅ Merged **Merged:** 5/6/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4584-id-filters` --- ### 📝 Commits (2) - [`4d5d298`](https://github.com/netbox-community/netbox/commit/4d5d298ee141e75f38500351c0a1fba6e767f78e) Update super() call for get_filters() - [`1ccb316`](https://github.com/netbox-community/netbox/commit/1ccb3162ff497923d6cd10767916ee2653d9a9e8) Ensure all model FilterSets support the 'id' field ### 📊 Changes **15 files changed** (+163 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/filters.py` (+2 -2) 📝 `netbox/circuits/tests/test_filters.py` (+8 -0) 📝 `netbox/dcim/filters.py` (+4 -4) 📝 `netbox/dcim/tests/test_filters.py` (+45 -57) 📝 `netbox/extras/filters.py` (+6 -5) 📝 `netbox/extras/tests/test_filters.py` (+44 -1) 📝 `netbox/ipam/filters.py` (+6 -6) 📝 `netbox/ipam/tests/test_filters.py` (+27 -6) 📝 `netbox/secrets/filters.py` (+1 -1) 📝 `netbox/secrets/tests/test_filters.py` (+5 -2) 📝 `netbox/tenancy/filters.py` (+1 -1) 📝 `netbox/tenancy/tests/test_filters.py` (+5 -2) 📝 `netbox/utilities/filters.py` (+1 -3) 📝 `netbox/virtualization/filters.py` (+1 -1) 📝 `netbox/virtualization/tests/test_filters.py` (+7 -6) </details> ### 📄 Description ### Fixes: #4584 - Updates all model-based FilterSets to support filtering by `id` - Extends filter tests as necessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:10 +01:00
adam closed this issue 2025-12-29 22:24:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12881
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?