starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4359] [MERGED] Closes #3416: Remove API _choices endpoints #12825

New Issue
Closed
opened 2025-12-29 22:23:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4359
Author: @jeremystretch
Created: 3/12/2020
Status: ✅ Merged
Merged: 3/12/2020
Merged by: @jeremystretch

Base: develop-2.8 ← Head: 3416-remove-API-choices

📝 Commits (3)

  • ea9de37 Remove FieldChoicesViewSet
  • a53f854 Remove tests for API _choices endpoints
  • ef5c20d Update documentation

📊 Changes

24 files changed (+37 additions, -411 deletions)

View changed files

📝 docs/api/overview.md (+25 -51)
📝 netbox/circuits/api/urls.py (+0 -3)
📝 netbox/circuits/api/views.py (+1 -12)
📝 netbox/circuits/tests/test_api.py (+1 -14)
📝 netbox/dcim/api/urls.py (+0 -3)
📝 netbox/dcim/api/views.py (+1 -30)
📝 netbox/dcim/tests/test_api.py (+1 -74)
📝 netbox/extras/api/urls.py (+0 -3)
📝 netbox/extras/api/views.py (+1 -13)
📝 netbox/extras/tests/test_api.py (+1 -24)
📝 netbox/ipam/api/urls.py (+0 -3)
📝 netbox/ipam/api/views.py (+1 -15)
📝 netbox/ipam/tests/test_api.py (+1 -26)
📝 netbox/secrets/api/urls.py (+0 -3)
📝 netbox/secrets/api/views.py (+1 -9)
📝 netbox/secrets/tests/test_api.py (+0 -7)
📝 netbox/tenancy/api/urls.py (+0 -3)
📝 netbox/tenancy/api/views.py (+1 -9)
📝 netbox/tenancy/tests/test_api.py (+0 -7)
📝 netbox/utilities/api.py (+0 -46)

...and 4 more files

📄 Description

Fixes: #3416

  • Remove _choices endpoint from each app within the REST API
  • Remove relevant tests
  • Update the documentation accordingly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4359 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 3/12/2020 **Status:** ✅ Merged **Merged:** 3/12/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.8` ← **Head:** `3416-remove-API-choices` --- ### 📝 Commits (3) - [`ea9de37`](https://github.com/netbox-community/netbox/commit/ea9de37dd1abfef2342ba2764b8e2fe0508136dc) Remove FieldChoicesViewSet - [`a53f854`](https://github.com/netbox-community/netbox/commit/a53f85418774b53088c72186562ca475cc07db03) Remove tests for API _choices endpoints - [`ef5c20d`](https://github.com/netbox-community/netbox/commit/ef5c20dc6fd3bf6366332ef498c80cea0970cdea) Update documentation ### 📊 Changes **24 files changed** (+37 additions, -411 deletions) <details> <summary>View changed files</summary> 📝 `docs/api/overview.md` (+25 -51) 📝 `netbox/circuits/api/urls.py` (+0 -3) 📝 `netbox/circuits/api/views.py` (+1 -12) 📝 `netbox/circuits/tests/test_api.py` (+1 -14) 📝 `netbox/dcim/api/urls.py` (+0 -3) 📝 `netbox/dcim/api/views.py` (+1 -30) 📝 `netbox/dcim/tests/test_api.py` (+1 -74) 📝 `netbox/extras/api/urls.py` (+0 -3) 📝 `netbox/extras/api/views.py` (+1 -13) 📝 `netbox/extras/tests/test_api.py` (+1 -24) 📝 `netbox/ipam/api/urls.py` (+0 -3) 📝 `netbox/ipam/api/views.py` (+1 -15) 📝 `netbox/ipam/tests/test_api.py` (+1 -26) 📝 `netbox/secrets/api/urls.py` (+0 -3) 📝 `netbox/secrets/api/views.py` (+1 -9) 📝 `netbox/secrets/tests/test_api.py` (+0 -7) 📝 `netbox/tenancy/api/urls.py` (+0 -3) 📝 `netbox/tenancy/api/views.py` (+1 -9) 📝 `netbox/tenancy/tests/test_api.py` (+0 -7) 📝 `netbox/utilities/api.py` (+0 -46) _...and 4 more files_ </details> ### 📄 Description ### Fixes: #3416 - Remove `_choices` endpoint from each app within the REST API - Remove relevant tests - Update the documentation accordingly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:49 +01:00
adam closed this issue 2025-12-29 22:23:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12825
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?