[PR #4258] [MERGED] Fixes: #4255 - Modify script ObjectVars to utilize DynamicModelChoiceField #12803

New Issue

adam · 2025-12-29T22:23:42+01:00

adam commented

2025-12-29 22:23:42 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4258
Author: @DanSheps
Created: 2/24/2020
Status: ✅ Merged
Merged: 3/19/2020
Merged by: @jeremystretch

Base: develop ← Head: 4255-dynamic_object_vars

📝 Commits (6)

d0bd1ad Fixes: #4255 - Add new script variable types based on dynamic model fields
a585342 Update all for <class 'django.contrib.auth.models.User.config.RelatedObjectDoesNotExist'> (#4255)
8ed0d04 Add tests
27e3b6f Remove second variables, make widget mandatory on ObjectVar and MultiObjectVar
0995e10 Modify script ObjectVars to use DynamicModelChoiceFields
fa1548f Remove extraneous import

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 netbox/extras/scripts.py (+3 -2)

📄 Description

Fixes: #4255

Adds two new fields that extend their related fields:

DynamicObjectVar
DynamicMultiObjectVar

Adds tests for those two new fields

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4258 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 2/24/2020 **Status:** ✅ Merged **Merged:** 3/19/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4255-dynamic_object_vars` --- ### 📝 Commits (6) - [`d0bd1ad`](https://github.com/netbox-community/netbox/commit/d0bd1ad25b168555725b1f53b4bace0a09cbe413) Fixes: #4255 - Add new script variable types based on dynamic model fields - [`a585342`](https://github.com/netbox-community/netbox/commit/a5853427d44aa56abb93c74401753a787d59a467) Update __all__ for #4255 - [`8ed0d04`](https://github.com/netbox-community/netbox/commit/8ed0d0400f5dcd5c784fac1fb41b1ec2a0245faf) Add tests - [`27e3b6f`](https://github.com/netbox-community/netbox/commit/27e3b6f377afb8c88e2e79ca805c335d15cff11a) Remove second variables, make widget mandatory on ObjectVar and MultiObjectVar - [`0995e10`](https://github.com/netbox-community/netbox/commit/0995e10d8720efe1af7c08cfd189ff6fafc47416) Modify script ObjectVars to use DynamicModelChoiceFields - [`fa1548f`](https://github.com/netbox-community/netbox/commit/fa1548f3cea7bca17ad3a82f79ee37ae93a8b3fb) Remove extraneous import ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/scripts.py` (+3 -2) </details> ### 📄 Description ### Fixes: #4255 Adds two new fields that extend their related fields: * DynamicObjectVar * DynamicMultiObjectVar Adds tests for those two new fields --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:23:42 +01:00

adam closed this issue

2025-12-29 22:23:43 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12803