starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4174] [MERGED] Closes #4164: Consolidate object list templates #12785

New Issue
Closed
opened 2025-12-29 22:23:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4174
Author: @jeremystretch
Created: 2/14/2020
Status: ✅ Merged
Merged: 2/14/2020
Merged by: @jeremystretch

Base: develop ← Head: 4164-object-list-template

📝 Commits (10+)

  • c5f74cc Introduce a common template for object list views
  • 4ef15e4 Migrate circuits views to use common object list template
  • fff657c Migrate DCIM views to use common object list template
  • 8fd809a Migrate IPAM views to use common object list template
  • a054aff Migrate secrets views to use common object list template
  • 88c9172 Migrate tenancy views to use common object list template
  • 6884404 Migrate virtualization views to use common object list template
  • ff952fb Migrate extras views to use common object list template
  • 8df9bb6 Convert change log view to extend standard template
  • 8212c8f Convert IPAM list views to extend standard template

📊 Changes

60 files changed (+181 additions, -982 deletions)

View changed files

📝 netbox/circuits/views.py (+0 -3)
📝 netbox/dcim/views.py (+12 -23)
📝 netbox/extras/views.py (+3 -2)
📝 netbox/ipam/views.py (+1 -7)
📝 netbox/secrets/views.py (+1 -2)
➖ netbox/templates/circuits/circuit_list.html (+0 -21)
➖ netbox/templates/circuits/circuittype_list.html (+0 -18)
➖ netbox/templates/circuits/provider_list.html (+0 -21)
➖ netbox/templates/dcim/cable_list.html (+0 -20)
➖ netbox/templates/dcim/consoleport_list.html (+0 -17)
➖ netbox/templates/dcim/consoleserverport_list.html (+0 -17)
📝 netbox/templates/dcim/device_list.html (+21 -18)
➖ netbox/templates/dcim/devicebay_list.html (+0 -17)
➖ netbox/templates/dcim/devicerole_list.html (+0 -18)
➖ netbox/templates/dcim/devicetype_list.html (+0 -21)
➖ netbox/templates/dcim/frontport_list.html (+0 -17)
➖ netbox/templates/dcim/inc/device_table.html (+0 -24)
➖ netbox/templates/dcim/interface_list.html (+0 -17)
➖ netbox/templates/dcim/inventoryitem_list.html (+0 -21)
➖ netbox/templates/dcim/manufacturer_list.html (+0 -18)

...and 40 more files

📄 Description

Fixes: #4164

Remove most of the individual foo_list.html templates in favor of a common obj_list.html template, and extend it with custom object list templates where necessary (devices, VMs, etc.).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4174 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/14/2020 **Status:** ✅ Merged **Merged:** 2/14/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4164-object-list-template` --- ### 📝 Commits (10+) - [`c5f74cc`](https://github.com/netbox-community/netbox/commit/c5f74cce805e7fb4a73745a41ddf1b8a5388e8f2) Introduce a common template for object list views - [`4ef15e4`](https://github.com/netbox-community/netbox/commit/4ef15e4dc89b90ef6c5ac6d5a401c6683177b29a) Migrate circuits views to use common object list template - [`fff657c`](https://github.com/netbox-community/netbox/commit/fff657cd5a2649bbfa7d84a7e119ce444009cdfc) Migrate DCIM views to use common object list template - [`8fd809a`](https://github.com/netbox-community/netbox/commit/8fd809ac5e9cfb36263293a624fb8f0a7656dd33) Migrate IPAM views to use common object list template - [`a054aff`](https://github.com/netbox-community/netbox/commit/a054aff3c431e44a4d2f395fd7cb06a4adb97b28) Migrate secrets views to use common object list template - [`88c9172`](https://github.com/netbox-community/netbox/commit/88c917231de849646544d1ea76c801f893f681c3) Migrate tenancy views to use common object list template - [`6884404`](https://github.com/netbox-community/netbox/commit/6884404957913501dd16062e9181be9d54edb84c) Migrate virtualization views to use common object list template - [`ff952fb`](https://github.com/netbox-community/netbox/commit/ff952fb2210f92f8ff643c60ccca2266d830903b) Migrate extras views to use common object list template - [`8df9bb6`](https://github.com/netbox-community/netbox/commit/8df9bb6fb47863a4f6376d0e5a29cd4b9ac84023) Convert change log view to extend standard template - [`8212c8f`](https://github.com/netbox-community/netbox/commit/8212c8f6fc596e5133e960cd8317cde85f8695d3) Convert IPAM list views to extend standard template ### 📊 Changes **60 files changed** (+181 additions, -982 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/views.py` (+0 -3) 📝 `netbox/dcim/views.py` (+12 -23) 📝 `netbox/extras/views.py` (+3 -2) 📝 `netbox/ipam/views.py` (+1 -7) 📝 `netbox/secrets/views.py` (+1 -2) ➖ `netbox/templates/circuits/circuit_list.html` (+0 -21) ➖ `netbox/templates/circuits/circuittype_list.html` (+0 -18) ➖ `netbox/templates/circuits/provider_list.html` (+0 -21) ➖ `netbox/templates/dcim/cable_list.html` (+0 -20) ➖ `netbox/templates/dcim/consoleport_list.html` (+0 -17) ➖ `netbox/templates/dcim/consoleserverport_list.html` (+0 -17) 📝 `netbox/templates/dcim/device_list.html` (+21 -18) ➖ `netbox/templates/dcim/devicebay_list.html` (+0 -17) ➖ `netbox/templates/dcim/devicerole_list.html` (+0 -18) ➖ `netbox/templates/dcim/devicetype_list.html` (+0 -21) ➖ `netbox/templates/dcim/frontport_list.html` (+0 -17) ➖ `netbox/templates/dcim/inc/device_table.html` (+0 -24) ➖ `netbox/templates/dcim/interface_list.html` (+0 -17) ➖ `netbox/templates/dcim/inventoryitem_list.html` (+0 -21) ➖ `netbox/templates/dcim/manufacturer_list.html` (+0 -18) _...and 40 more files_ </details> ### 📄 Description ### Fixes: #4164 Remove most of the individual `foo_list.html` templates in favor of a common `obj_list.html` template, and extend it with custom object list templates where necessary (devices, VMs, etc.). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:35 +01:00
adam closed this issue 2025-12-29 22:23:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12785
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?