starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4112] [MERGED] Closes #4109: Add view tests for device component templates #12759

New Issue
Closed
opened 2025-12-29 22:23:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4112
Author: @jeremystretch
Created: 2/6/2020
Status: ✅ Merged
Merged: 2/6/2020
Merged by: @jeremystretch

Base: develop ← Head: 4109-devicetype-component-tests

📝 Commits (7)

  • 85729f3 Simplify help_text for ExpandableNameField
  • ef4ea06 Reorganized device component URLs (again)
  • aebfb14 Rename component template deletion URLs
  • c179265 Rename device component edit URLs
  • d400f92 Overhaul device component template creation views/URLs
  • f7ca97d Fix bulk edit buttons
  • 5620fdc Add tests for device type component views

📊 Changes

8 files changed (+491 additions, -96 deletions)

View changed files

📝 netbox/dcim/forms.py (+59 -6)
📝 netbox/dcim/tests/test_views.py (+366 -0)
📝 netbox/dcim/urls.py (+39 -38)
📝 netbox/dcim/views.py (+0 -25)
📝 netbox/templates/dcim/devicetype.html (+16 -16)
📝 netbox/templates/dcim/inc/devicetype_component_table.html (+3 -3)
📝 netbox/utilities/forms.py (+8 -6)
📝 netbox/utilities/views.py (+0 -2)

📄 Description

Fixes: #4109

  • Standardize component template URLs
  • Add tests for component template views

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4112 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/6/2020 **Status:** ✅ Merged **Merged:** 2/6/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4109-devicetype-component-tests` --- ### 📝 Commits (7) - [`85729f3`](https://github.com/netbox-community/netbox/commit/85729f3df81dcbe26d7dd54d747b918efd36fac6) Simplify help_text for ExpandableNameField - [`ef4ea06`](https://github.com/netbox-community/netbox/commit/ef4ea06f5de675b069c3c23b9060094cf768e050) Reorganized device component URLs (again) - [`aebfb14`](https://github.com/netbox-community/netbox/commit/aebfb143e0df611ef1eda92f3e821170afa4b108) Rename component template deletion URLs - [`c179265`](https://github.com/netbox-community/netbox/commit/c1792653cc608108229c71dfc3f5460c2e0ec334) Rename device component edit URLs - [`d400f92`](https://github.com/netbox-community/netbox/commit/d400f92ee84bbe5387c1fee6a760a2e1daf0f45f) Overhaul device component template creation views/URLs - [`f7ca97d`](https://github.com/netbox-community/netbox/commit/f7ca97d51fc38bb38d8f20eb611a1e5ace12de6c) Fix bulk edit buttons - [`5620fdc`](https://github.com/netbox-community/netbox/commit/5620fdc63ec0c759be5c8cc89d55a92eb4567910) Add tests for device type component views ### 📊 Changes **8 files changed** (+491 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+59 -6) 📝 `netbox/dcim/tests/test_views.py` (+366 -0) 📝 `netbox/dcim/urls.py` (+39 -38) 📝 `netbox/dcim/views.py` (+0 -25) 📝 `netbox/templates/dcim/devicetype.html` (+16 -16) 📝 `netbox/templates/dcim/inc/devicetype_component_table.html` (+3 -3) 📝 `netbox/utilities/forms.py` (+8 -6) 📝 `netbox/utilities/views.py` (+0 -2) </details> ### 📄 Description ### Fixes: #4109 - Standardize component template URLs - Add tests for component template views --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:27 +01:00
adam closed this issue 2025-12-29 22:23:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12759
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?