starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4080] [MERGED] Closes #4077: Add tests for bulk edit/delete views #12752

New Issue
Closed
opened 2025-12-29 22:23:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4080
Author: @jeremystretch
Created: 2/3/2020
Status: ✅ Merged
Merged: 2/3/2020
Merged by: @jeremystretch

Base: develop ← Head: 4077-view-tests

📝 Commits (7)

  • 24ab082 Add bulk delete view tests
  • a4aadf7 Correct default_return_url for TagBulkEditView
  • c3bd188 Correct nullable_fields for ServiceBulkEditForm
  • 4aa694f Skip non-model fields when applying bulk changes
  • d431efb Add bulk edit view tests
  • 7b4f3e8 Correct view for PowerFeed creation URL
  • 3f13441 Add view tests for power panels and power feeds

📊 Changes

12 files changed (+643 additions, -149 deletions)

View changed files

📝 netbox/circuits/tests/test_views.py (+37 -10)
📝 netbox/dcim/tests/test_views.py (+289 -66)
📝 netbox/dcim/urls.py (+1 -1)
📝 netbox/extras/tests/test_views.py (+12 -1)
📝 netbox/extras/views.py (+1 -2)
📝 netbox/ipam/forms.py (+1 -1)
📝 netbox/ipam/tests/test_views.py (+111 -29)
📝 netbox/secrets/tests/test_views.py (+27 -9)
📝 netbox/tenancy/tests/test_views.py (+14 -5)
📝 netbox/utilities/testing/testcases.py (+72 -2)
📝 netbox/utilities/views.py (+9 -5)
📝 netbox/virtualization/tests/test_views.py (+69 -18)

📄 Description

Fixes: #4077

  • Extend StandardTestCases.Views to add test methods for bulk edit and bulk delete views
  • Add missing tests for PowerPanel and PowerFeed views

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4080 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/3/2020 **Status:** ✅ Merged **Merged:** 2/3/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4077-view-tests` --- ### 📝 Commits (7) - [`24ab082`](https://github.com/netbox-community/netbox/commit/24ab0826743474ef3414aa81fd1e99a4eb16fe5f) Add bulk delete view tests - [`a4aadf7`](https://github.com/netbox-community/netbox/commit/a4aadf730c42e79ea9f9b8785668aa71bbc3b5c5) Correct default_return_url for TagBulkEditView - [`c3bd188`](https://github.com/netbox-community/netbox/commit/c3bd1881f527f747b2afb4fd68265b498d0a0c03) Correct nullable_fields for ServiceBulkEditForm - [`4aa694f`](https://github.com/netbox-community/netbox/commit/4aa694f04422ebafbf109be5fff6dbe51dd2937b) Skip non-model fields when applying bulk changes - [`d431efb`](https://github.com/netbox-community/netbox/commit/d431efb7d433d7ee2ae763b0ae7ed8b07be40fc4) Add bulk edit view tests - [`7b4f3e8`](https://github.com/netbox-community/netbox/commit/7b4f3e82615db94bef6421155cde965ead30e8f7) Correct view for PowerFeed creation URL - [`3f13441`](https://github.com/netbox-community/netbox/commit/3f13441a5d6af34c28d2b4698cc08cbe73753afa) Add view tests for power panels and power feeds ### 📊 Changes **12 files changed** (+643 additions, -149 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/tests/test_views.py` (+37 -10) 📝 `netbox/dcim/tests/test_views.py` (+289 -66) 📝 `netbox/dcim/urls.py` (+1 -1) 📝 `netbox/extras/tests/test_views.py` (+12 -1) 📝 `netbox/extras/views.py` (+1 -2) 📝 `netbox/ipam/forms.py` (+1 -1) 📝 `netbox/ipam/tests/test_views.py` (+111 -29) 📝 `netbox/secrets/tests/test_views.py` (+27 -9) 📝 `netbox/tenancy/tests/test_views.py` (+14 -5) 📝 `netbox/utilities/testing/testcases.py` (+72 -2) 📝 `netbox/utilities/views.py` (+9 -5) 📝 `netbox/virtualization/tests/test_views.py` (+69 -18) </details> ### 📄 Description ### Fixes: #4077 - Extend StandardTestCases.Views to add test methods for bulk edit and bulk delete views - Add missing tests for PowerPanel and PowerFeed views --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:25 +01:00
adam closed this issue 2025-12-29 22:23:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12752
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?