starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4066] [CLOSED] Fixes: #3016 - Add wrapper for post_save and post_delete signals #12746

New Issue
Closed
opened 2025-12-29 22:23:24 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:24 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4066
Author: @DanSheps
Created: 1/31/2020
Status: ❌ Closed

Base: develop ← Head: 3016-fix_post_save_exception_with_loaddata

📝 Commits (1)

  • 12db28f Fixes: #3016 - Add wrapper for post_save and post_delete signals

📊 Changes

3 files changed (+19 additions, -0 deletions)

View changed files

📝 netbox/circuits/signals.py (+3 -0)
📝 netbox/dcim/signals.py (+6 -0)
📝 netbox/extras/signals.py (+10 -0)

📄 Description

Fixes: #3016

This PR adds a wrapper for post_save and post_delete signals to handle when loaddata is called.

Solution was contributed by @Grokzen in his initial description. Decorator connected to both dcim/signals.py and circuits/signals.py

There is also the ObjectChangedMiddleware which I am not sure if we want to slide it around there as well, or if we need to.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4066 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 1/31/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `3016-fix_post_save_exception_with_loaddata` --- ### 📝 Commits (1) - [`12db28f`](https://github.com/netbox-community/netbox/commit/12db28fab66fe11cfc2c04549d4c1e55478344f0) Fixes: #3016 - Add wrapper for post_save and post_delete signals ### 📊 Changes **3 files changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/signals.py` (+3 -0) 📝 `netbox/dcim/signals.py` (+6 -0) 📝 `netbox/extras/signals.py` (+10 -0) </details> ### 📄 Description ### Fixes: #3016 This PR adds a wrapper for post_save and post_delete signals to handle when loaddata is called. Solution was contributed by @Grokzen in his initial description. Decorator connected to both dcim/signals.py and circuits/signals.py There is also the ObjectChangedMiddleware which I am not sure if we want to slide it around there as well, or if we need to. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:24 +01:00
adam closed this issue 2025-12-29 22:23:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?