starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4026] [MERGED] Fixes #4025: Cable status class #12732

New Issue
Closed
opened 2025-12-29 22:23:19 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:19 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4026
Author: @hSaria
Created: 1/27/2020
Status: ✅ Merged
Merged: 1/28/2020
Merged by: @jeremystretch

Base: develop ← Head: 4025-cable-status-class

📝 Commits (3)

  • 3bce8e9 Fixes #4025: Cable status class
  • 8306976 Removed erroneous double-space
  • 720bd87 Fixed interface mark connected/planned buttons

📊 Changes

9 files changed (+9 additions, -9 deletions)

View changed files

📝 netbox/templates/dcim/cable_trace.html (+1 -1)
📝 netbox/templates/dcim/inc/cable_toggle_buttons.html (+1 -1)
📝 netbox/templates/dcim/inc/consoleport.html (+1 -1)
📝 netbox/templates/dcim/inc/consoleserverport.html (+1 -1)
📝 netbox/templates/dcim/inc/frontport.html (+1 -1)
📝 netbox/templates/dcim/inc/interface.html (+1 -1)
📝 netbox/templates/dcim/inc/poweroutlet.html (+1 -1)
📝 netbox/templates/dcim/inc/powerport.html (+1 -1)
📝 netbox/templates/dcim/inc/rearport.html (+1 -1)

📄 Description

Fixes: #4025

The cable's class was being derived incorrectly, thus always evaluating to success even when the status is planned (should be info).

In addition to the colors, the mark connected/planned was always evaluating to Mark planned even when it already is.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4026 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/27/2020 **Status:** ✅ Merged **Merged:** 1/28/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4025-cable-status-class` --- ### 📝 Commits (3) - [`3bce8e9`](https://github.com/netbox-community/netbox/commit/3bce8e97160ef082d4c58cea93a23ab2ed230c14) Fixes #4025: Cable status class - [`8306976`](https://github.com/netbox-community/netbox/commit/8306976b3ee8734c2f3a2008a59f95ceda597ffb) Removed erroneous double-space - [`720bd87`](https://github.com/netbox-community/netbox/commit/720bd872921f398fbff35d42dd5598bdaa1733ce) Fixed interface mark connected/planned buttons ### 📊 Changes **9 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/dcim/cable_trace.html` (+1 -1) 📝 `netbox/templates/dcim/inc/cable_toggle_buttons.html` (+1 -1) 📝 `netbox/templates/dcim/inc/consoleport.html` (+1 -1) 📝 `netbox/templates/dcim/inc/consoleserverport.html` (+1 -1) 📝 `netbox/templates/dcim/inc/frontport.html` (+1 -1) 📝 `netbox/templates/dcim/inc/interface.html` (+1 -1) 📝 `netbox/templates/dcim/inc/poweroutlet.html` (+1 -1) 📝 `netbox/templates/dcim/inc/powerport.html` (+1 -1) 📝 `netbox/templates/dcim/inc/rearport.html` (+1 -1) </details> ### 📄 Description ### Fixes: #4025 The cable's class was being derived incorrectly, thus always evaluating to `success` even when the status is planned (should be `info`). In addition to the colors, the mark connected/planned was always evaluating to `Mark planned` even when it already is. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:19 +01:00
adam closed this issue 2025-12-29 22:23:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?