starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4013] [CLOSED] Fixes #3249: Description length #12730

New Issue
Closed
opened 2025-12-29 22:23:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4013
Author: @hSaria
Created: 1/25/2020
Status: ❌ Closed

Base: develop ← Head: 3249-description-length

📝 Commits (2)

📊 Changes

21 files changed (+300 additions, -46 deletions)

View changed files

📝 netbox/circuits/forms.py (+2 -1)
➕ netbox/circuits/migrations/0008_alter_description_max_length.py (+28 -0)
📝 netbox/circuits/models.py (+4 -3)
📝 netbox/dcim/forms.py (+17 -14)
➕ netbox/dcim/migrations/0092_alter_description_max_length.py (+78 -0)
📝 netbox/dcim/models/__init__.py (+5 -4)
📝 netbox/dcim/models/device_components.py (+2 -1)
📝 netbox/extras/constants.py (+3 -0)
📝 netbox/extras/forms.py (+2 -1)
➕ netbox/extras/migrations/0037_alter_description_max_length.py (+28 -0)
📝 netbox/extras/models.py (+3 -3)
📝 netbox/ipam/forms.py (+7 -6)
➕ netbox/ipam/migrations/0034_alter_description_max_length.py (+48 -0)
📝 netbox/ipam/models.py (+8 -7)
➕ netbox/secrets/migrations/0008_alter_description_max_length.py (+18 -0)
📝 netbox/secrets/models.py (+2 -1)
➕ netbox/tenancy/migrations/0007_alter_description_max_length.py (+18 -0)
📝 netbox/tenancy/models.py (+2 -1)
➕ netbox/users/migrations/0002_alter_description_max_length.py (+18 -0)
📝 netbox/users/models.py (+3 -1)

...and 1 more files

📄 Description

Fixes: #3249

Increased the description max_length from 100 to 256 (see #3249 for info on why that number).

In the process, I've replaced that number with a constant which addresses an inconsistency in ExportTemplate where description had 200.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4013 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/25/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `3249-description-length` --- ### 📝 Commits (2) - [`dbc721f`](https://github.com/netbox-community/netbox/commit/dbc721fc2a98dfedfd5cbd5e8e65794f4e411819) Moved description max length to constant - [`1efbd57`](https://github.com/netbox-community/netbox/commit/1efbd576ca249498fbe66d7e094e0187c08c5e6e) Fixes #3249: Description max length ### 📊 Changes **21 files changed** (+300 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/forms.py` (+2 -1) ➕ `netbox/circuits/migrations/0008_alter_description_max_length.py` (+28 -0) 📝 `netbox/circuits/models.py` (+4 -3) 📝 `netbox/dcim/forms.py` (+17 -14) ➕ `netbox/dcim/migrations/0092_alter_description_max_length.py` (+78 -0) 📝 `netbox/dcim/models/__init__.py` (+5 -4) 📝 `netbox/dcim/models/device_components.py` (+2 -1) 📝 `netbox/extras/constants.py` (+3 -0) 📝 `netbox/extras/forms.py` (+2 -1) ➕ `netbox/extras/migrations/0037_alter_description_max_length.py` (+28 -0) 📝 `netbox/extras/models.py` (+3 -3) 📝 `netbox/ipam/forms.py` (+7 -6) ➕ `netbox/ipam/migrations/0034_alter_description_max_length.py` (+48 -0) 📝 `netbox/ipam/models.py` (+8 -7) ➕ `netbox/secrets/migrations/0008_alter_description_max_length.py` (+18 -0) 📝 `netbox/secrets/models.py` (+2 -1) ➕ `netbox/tenancy/migrations/0007_alter_description_max_length.py` (+18 -0) 📝 `netbox/tenancy/models.py` (+2 -1) ➕ `netbox/users/migrations/0002_alter_description_max_length.py` (+18 -0) 📝 `netbox/users/models.py` (+3 -1) _...and 1 more files_ </details> ### 📄 Description ### Fixes: #3249 Increased the description `max_length` from 100 to 256 (see #3249 for info on why that number). In the process, I've replaced that number with a constant which addresses an inconsistency in `ExportTemplate` where description had 200. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:18 +01:00
adam closed this issue 2025-12-29 22:23:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12730
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?