[PR #3973] [MERGED] dcim: fix tooltips in svg rack display #12715

Closed
opened 2025-12-29 22:23:12 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3973
Author: @hellerve
Created: 1/21/2020
Status: Merged
Merged: 1/21/2020
Merged by: @jeremystretch

Base: developHead: veit/fix-3963


📝 Commits (1)

  • 469a088 dcim: fix tooltips in svg rack display

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 netbox/dcim/models/__init__.py (+10 -1)

📄 Description

Fixes: #3963

This PR fixes #3963 by adding a title to the individual slots of the element. Those are rendered as follows:

Bildschirmfoto 2020-01-21 um 16 19 01

So they aren’t quite as pretty and feature-rich as the old ones, but they show the same information. To emulate the old ones we have to tinker a little with JavaScript I fear, and I don’t feel equipped to do that in the SVG context.

@candlerb can you confirm that this is what you expected?

Cheers


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3973 **Author:** [@hellerve](https://github.com/hellerve) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/21/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `veit/fix-3963` --- ### 📝 Commits (1) - [`469a088`](https://github.com/netbox-community/netbox/commit/469a08887431df0563e5df3007b02badcf2d1eab) dcim: fix tooltips in svg rack display ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/__init__.py` (+10 -1) </details> ### 📄 Description ### Fixes: #3963 This PR fixes #3963 by adding a `title` to the individual slots of the element. Those are rendered as follows: <img width="308" alt="Bildschirmfoto 2020-01-21 um 16 19 01" src="https://user-images.githubusercontent.com/7725188/72817391-fb165980-3c69-11ea-8eb0-a1cd3c49c7e9.png"> So they aren’t quite as pretty and feature-rich as the old ones, but they show the same information. To emulate the old ones we have to tinker a little with JavaScript I fear, and I don’t feel equipped to do that in the SVG context. @candlerb can you confirm that this is what you expected? Cheers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:12 +01:00
adam closed this issue 2025-12-29 22:23:13 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12715