[PR #3972] [MERGED] Display borders around devices in rack elevations #12713

New Issue

adam · 2025-12-29T22:23:12+01:00

adam commented

2025-12-29 22:23:12 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3972
Author: @hellerve
Created: 1/21/2020
Status: ✅ Merged
Merged: 1/21/2020
Merged by: @jeremystretch

Base: develop ← Head: veit/fix-3964

📝 Commits (2)

5f3f212 dcim: fix #3964 by moving away from properties to inline styles
a7a166a Merge branch 'develop' into veit/fix-3964

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/dcim/models/__init__.py (+1 -1)

📄 Description

Fixes: #3964

This PR fixes #3964 by moving away from a property an inline style for the fill, and adding the right class to a slot. Why an inline style? Because I learned that the override chain for properties in SVG is a little counterintuitive:

Properties such as <rect fill="#eee"> bind least strongly.
External stylesheets bind more strongly.
Inline style such as <rect style="fill: #eee"> binds most strongly, and can be overridden only by using !important.

Funny, no? Anyway, now the classes are set correctly, and the borders are back!

Cheers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3972 **Author:** [@hellerve](https://github.com/hellerve) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/21/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `veit/fix-3964` --- ### 📝 Commits (2) - [`5f3f212`](https://github.com/netbox-community/netbox/commit/5f3f21215a46e39c98293a15ff030b78e5ca138e) dcim: fix #3964 by moving away from properties to inline styles - [`a7a166a`](https://github.com/netbox-community/netbox/commit/a7a166a9cbfa48c361a8903ef2345c2e0d07d5ee) Merge branch 'develop' into veit/fix-3964 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/__init__.py` (+1 -1) </details> ### 📄 Description ### Fixes: #3964 This PR fixes #3964 by moving away from a property an inline style for the fill, and adding the right class to a slot. Why an inline style? Because I learned that the override chain for properties in SVG is a little counterintuitive: - Properties such as `<rect fill="#eee">` bind least strongly. - External stylesheets bind more strongly. - Inline style such as `<rect style="fill: #eee">` binds most strongly, and can be overridden only by using `!important`. Funny, no? Anyway, now the classes are set correctly, and the borders are back! Cheers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:23:12 +01:00

adam closed this issue

2025-12-29 22:23:12 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12713