starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3922] [MERGED] Closes #3921: Add tests for API _choices endpoints #12698

New Issue
Closed
opened 2025-12-29 22:23:07 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3922
Author: @jeremystretch
Created: 1/14/2020
Status: ✅ Merged
Merged: 1/14/2020
Merged by: @jeremystretch

Base: develop-2.7 ← Head: 3921-choices-tests

📝 Commits (3)

  • 3f37cc4 Reorder operations to avoid "pending trigger events" SQL error
  • 857e04e Add _choices endpoint tests for all apps
  • 8df53ea Add tests for dynamic choices

📊 Changes

12 files changed (+232 additions, -15 deletions)

View changed files

📝 netbox/circuits/tests/test_api.py (+17 -1)
📝 netbox/dcim/api/views.py (+1 -0)
📝 netbox/dcim/tests/test_api.py (+77 -1)
📝 netbox/extras/tests/test_api.py (+28 -1)
📝 netbox/ipam/choices.py (+1 -1)
📝 netbox/ipam/tests/test_api.py (+30 -2)
📝 netbox/secrets/tests/test_api.py (+10 -0)
📝 netbox/tenancy/tests/test_api.py (+10 -0)
📝 netbox/utilities/choices.py (+8 -0)
📝 netbox/utilities/testing.py (+27 -0)
📝 netbox/virtualization/migrations/0010_cluster_add_tenant_squashed_0012_vm_name_nonunique.py (+8 -8)
📝 netbox/virtualization/tests/test_api.py (+15 -1)

📄 Description

Fixes: #3921

Add unit tests for all /api/*/_choices/ endpoints

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3922 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 1/14/2020 **Status:** ✅ Merged **Merged:** 1/14/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.7` ← **Head:** `3921-choices-tests` --- ### 📝 Commits (3) - [`3f37cc4`](https://github.com/netbox-community/netbox/commit/3f37cc461d5350cefacbb12701fdb4d69083c43e) Reorder operations to avoid "pending trigger events" SQL error - [`857e04e`](https://github.com/netbox-community/netbox/commit/857e04e90b566fff883833af979b4caa9c4313ae) Add _choices endpoint tests for all apps - [`8df53ea`](https://github.com/netbox-community/netbox/commit/8df53eac913428b63e7211c0beb1ab50ff70167d) Add tests for dynamic choices ### 📊 Changes **12 files changed** (+232 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/tests/test_api.py` (+17 -1) 📝 `netbox/dcim/api/views.py` (+1 -0) 📝 `netbox/dcim/tests/test_api.py` (+77 -1) 📝 `netbox/extras/tests/test_api.py` (+28 -1) 📝 `netbox/ipam/choices.py` (+1 -1) 📝 `netbox/ipam/tests/test_api.py` (+30 -2) 📝 `netbox/secrets/tests/test_api.py` (+10 -0) 📝 `netbox/tenancy/tests/test_api.py` (+10 -0) 📝 `netbox/utilities/choices.py` (+8 -0) 📝 `netbox/utilities/testing.py` (+27 -0) 📝 `netbox/virtualization/migrations/0010_cluster_add_tenant_squashed_0012_vm_name_nonunique.py` (+8 -8) 📝 `netbox/virtualization/tests/test_api.py` (+15 -1) </details> ### 📄 Description ### Fixes: #3921 Add unit tests for all `/api/*/_choices/` endpoints --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:07 +01:00
adam closed this issue 2025-12-29 22:23:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12698
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?