[PR #3913] [CLOSED] Fixes #3912: Remove chaining (now handled via APISelect) #12692

New Issue

adam · 2025-12-29T22:23:05+01:00

adam commented

2025-12-29 22:23:05 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3913
Author: @hSaria
Created: 1/13/2020
Status: ❌ Closed

Base: develop ← Head: 3912-remove-chaining

📝 Commits (2)

a529403 Fixes #3912: Remove chaining (now handled via APISelect)
18ba11f Merge branch 'develop' into 3912-remove-chaining

📊 Changes

5 files changed (+40 additions, -191 deletions)

View changed files

📝 netbox/dcim/forms.py (+21 -64)
📝 netbox/ipam/forms.py (+9 -29)
📝 netbox/tenancy/forms.py (+3 -9)
📝 netbox/utilities/forms.py (+0 -68)
📝 netbox/virtualization/forms.py (+7 -21)

📄 Description

Fixes: #3912

Chaining has been superseded by APISelect. Apart from the initial loading, the queryset has no barring on the operation of APISelect – those widgets use the api_url, filter_for, and additional_query_params.

As you scroll down the diff list, you'll notice that every field and its chain that was changed has an APISelect widget.

I don't know whether or not to create a changelog entry for a housekeeping change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3913 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/13/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `3912-remove-chaining` --- ### 📝 Commits (2) - [`a529403`](https://github.com/netbox-community/netbox/commit/a5294036e81d0ec447c7374e4c9e35f8f0ad62a2) Fixes #3912: Remove chaining (now handled via APISelect) - [`18ba11f`](https://github.com/netbox-community/netbox/commit/18ba11fb1b3fb5824d22e8bae3530565045a57e8) Merge branch 'develop' into 3912-remove-chaining ### 📊 Changes **5 files changed** (+40 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+21 -64) 📝 `netbox/ipam/forms.py` (+9 -29) 📝 `netbox/tenancy/forms.py` (+3 -9) 📝 `netbox/utilities/forms.py` (+0 -68) 📝 `netbox/virtualization/forms.py` (+7 -21) </details> ### 📄 Description ### Fixes: #3912 Chaining has been superseded by APISelect. Apart from the initial loading, the queryset has no barring on the operation of APISelect – those widgets use the `api_url`, `filter_for`, and `additional_query_params`. As you scroll down the diff list, you'll notice that every field and its chain that was changed has an APISelect widget. > I don't know whether or not to create a changelog entry for a housekeeping change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:23:05 +01:00

adam closed this issue

2025-12-29 22:23:05 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12692